From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claudiu Manoil <claudiu.manoil@freescale.com>
Date: Mon, 7 Oct 2013 13:16:56 +0300
Subject: [U-Boot] [PATCH 7/9][v2] net: tsec: Use portable types and
 accessors for BDs
In-Reply-To: <CAOZdJXW8L-S+ETfumF-UfqpBhjj=bRnfDwuaFTiz5mQ+fUCpSA@mail.gmail.com>
References: <1380752101.12932.127.camel@snotra.buserror.net>
	<1380800932-22552-1-git-send-email-claudiu.manoil@freescale.com>
	<1380825428.12932.154.camel@snotra.buserror.net>
	<524E7BEA.2070103@freescale.com>
	<1380901846.7979.2.camel@snotra.buserror.net>
	<524EEC04.1030105@freescale.com>
	<CAOZdJXW8L-S+ETfumF-UfqpBhjj=bRnfDwuaFTiz5mQ+fUCpSA@mail.gmail.com>
Message-ID: <52528A18.6090407@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 10/5/2013 5:31 PM, Timur Tabi wrote:
> On Fri, Oct 4, 2013 at 11:25 AM, Claudiu Manoil
> <claudiu.manoil@freescale.com> wrote:
>
>> [v3] declaring the BDs as __iomem to avoid casting submitted:
>> http://patchwork.ozlabs.org/patch/280664/
>
> + out_be32(&regs->tbase, (u32)&txbd[0]);
> + out_be32(&regs->rbase, (u32)&rxbd[0]);
>
> &rxbd[0] is a virtual address.
>
> Doesn't rbase require a physical address?  You're assuming that virt == phys.
>
>

These SoCs don't feature IOMMU so it cannot be a virtual address.
I think you're suggesting that virt_to_phys() should be used
to fix that, right?  However, virt_to_phys() is equivalent to that
simple cast in most cases as there's no CONFIG_PHYS_64BIT for the
platforms with eTSEC. I'm actually not sure if there's a platform
with eTSEC for which that cast wouldn't be enough.

If so, it should be a separate patch as this fix would apply to
existing (old) code and is out of the scope of this patch about
portable accessors.

Thanks.
Claudiu