From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Date: Mon, 07 Oct 2013 07:05:35 -0500 Subject: [U-Boot] [PATCH 7/9][v2] net: tsec: Use portable types and accessors for BDs In-Reply-To: <52528A18.6090407@freescale.com> References: <1380752101.12932.127.camel@snotra.buserror.net> <1380800932-22552-1-git-send-email-claudiu.manoil@freescale.com> <1380825428.12932.154.camel@snotra.buserror.net> <524E7BEA.2070103@freescale.com> <1380901846.7979.2.camel@snotra.buserror.net> <524EEC04.1030105@freescale.com> <52528A18.6090407@freescale.com> Message-ID: <5252A38F.9070305@tabi.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Claudiu Manoil wrote: > I think you're suggesting that virt_to_phys() should be used > to fix that, right? Yes. > However, virt_to_phys() is equivalent to that > simple cast in most cases as there's no CONFIG_PHYS_64BIT for the > platforms with eTSEC. I'm actually not sure if there's a platform > with eTSEC for which that cast wouldn't be enough. Freescale might create a eTSEC-compatible 10G NIC one day that does run on e6500 cores. > If so, it should be a separate patch as this fix would apply to > existing (old) code and is out of the scope of this patch about > portable accessors. Fair enough.