From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Mon, 07 Oct 2013 10:14:12 -0600 Subject: [U-Boot] [PATCH] Fix number base handling of "load" command In-Reply-To: <1381000045-5938-1-git-send-email-wd@denx.de> References: <1380901758-30360-1-git-send-email-trini@ti.com> <1381000045-5938-1-git-send-email-wd@denx.de> Message-ID: <5252DDD4.8030300@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/05/2013 01:07 PM, Wolfgang Denk wrote: > A documented, almost all U-Boot commands expect numbers to be entered s/A/As/ (btw, where?) > in hexadecimal input format. (Exception: for historical reasons, the > "sleep" command takes its argument in decimal input format.) > > This rule was broken for the "load" command; for details please see > especially commits 045fa1e "fs: add filesystem switch libary, > implement ls and fsload commands" and 3f83c87 "fs: fix number base > behaviour change in fatload/ext*load". In the result, the load > command would always require an explicit "0x" prefix for regular > (i. e. base 16 formatted) input. > > Change this to use the standard notation of base 16 input format. > While strictly speaking this is a change of the user interface, we > hope that it will not cause trouble. Stephen Warren comments (see > [1]): > > I suppose you can change the behaviour if you want; anyone > writing "0x..." for their values presumably won't be > affected, and if people really do assume all values in U-Boot > are in hex, presumably nobody currently relies upon using > non-prefixed values with the generic load command, since it > doesn't work like that right now. > > [1] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/171172 Acked-by: Stephen Warren