From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: Tegra: T114: Use common tegra1x4- includes in arch-tegra
Date: Tue, 08 Oct 2013 16:10:16 -0600 [thread overview]
Message-ID: <525482C8.7000800@wwwdotorg.org> (raw)
In-Reply-To: <1381264053-12688-1-git-send-email-twarren@nvidia.com>
On 10/08/2013 02:27 PM, Tom Warren wrote:
> A previous commit created common arch-tegra/tegra1x4-xxx header
> files for T124, based on the existing T114 headers (HW is nearly
> 100% compatible for most blocks). Now that T124 support is in,
> move T114 over to use those common headers (which are actually
> copies of the T114 headers). Some headers aren't shared, such
> as clk_rst.h, gpio.h, pmc.h, etc. as they have extra regs/bits
> for T124.
> arch/arm/include/asm/arch-tegra114/pmc.h | 343 ++++++++++++++++++++++
How come that one file was created and is so large? If this patch is
just about making Tegra114 files use the common files where possible, I
wouldn't have expected any new Tegra114-specific files to be added. Is
arch/arm/include/asm/arch-tegra/pmc.h wrong for Tegra114? If so, fixing
that seems like it should be a separate patch.
prev parent reply other threads:[~2013-10-08 22:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 20:27 [U-Boot] [PATCH] arm: Tegra: T114: Use common tegra1x4- includes in arch-tegra Tom Warren
2013-10-08 22:10 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525482C8.7000800@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox