From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Tue, 08 Oct 2013 16:10:16 -0600 Subject: [U-Boot] [PATCH] arm: Tegra: T114: Use common tegra1x4- includes in arch-tegra In-Reply-To: <1381264053-12688-1-git-send-email-twarren@nvidia.com> References: <1381264053-12688-1-git-send-email-twarren@nvidia.com> Message-ID: <525482C8.7000800@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/08/2013 02:27 PM, Tom Warren wrote: > A previous commit created common arch-tegra/tegra1x4-xxx header > files for T124, based on the existing T114 headers (HW is nearly > 100% compatible for most blocks). Now that T124 support is in, > move T114 over to use those common headers (which are actually > copies of the T114 headers). Some headers aren't shared, such > as clk_rst.h, gpio.h, pmc.h, etc. as they have extra regs/bits > for T124. > arch/arm/include/asm/arch-tegra114/pmc.h | 343 ++++++++++++++++++++++ How come that one file was created and is so large? If this patch is just about making Tegra114 files use the common files where possible, I wouldn't have expected any new Tegra114-specific files to be added. Is arch/arm/include/asm/arch-tegra/pmc.h wrong for Tegra114? If so, fixing that seems like it should be a separate patch.