public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: mxs: Setup stack in JTAG mode
Date: Thu, 10 Oct 2013 17:20:07 +0200	[thread overview]
Message-ID: <5256C5A7.8010802@denx.de> (raw)
In-Reply-To: <1379633804-7751-1-git-send-email-marex@denx.de>

On 20/09/2013 01:36, Marek Vasut wrote:
> In case the MX23/MX28 is switched into JTAG mode via the BootMode select
> switches, the BootROM bypasses the CPU core registers initialization.
> This in turn means that the Stack Pointer (SP) register is not set as
> it is in every other mode of operation, but instead is only zeroed out.
> 
> To prevent U-Boot SPL from crashing in this obscure JTAG mode, configure
> the SP to point at the CONFIG_SYS_INIT_SP_ADDR if the SP is zeroed out.
> 
> Note that in case the SP is already configured, we must preserve that exact
> SP value and must not modify it. This is important since in every other mode
> but the JTAG mode, the SPL returns into the BootROM and BootROM in turn loads
> U-Boot itself. If the SP were to be corrupted, the BootROM won't be able to
> continue it's operation after returned from SPL and the system would crash.
> 
> Finally, add the JTAG mode switch identifier, so it's not recognised as
> Unknown mode.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Otavio Salvador <otavio@ossystems.com.br>
> ---

Applied to u-boot-imx, -next branch, thanks !

Best regards,
Stefano Babic




-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

      reply	other threads:[~2013-10-10 15:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-19 23:36 [U-Boot] [PATCH] ARM: mxs: Setup stack in JTAG mode Marek Vasut
2013-10-10 15:20 ` Stefano Babic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5256C5A7.8010802@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox