* [U-Boot] [RFC] i2c_reloc_fixup fails on m68k
@ 2013-09-23 13:50 Jens Scharsig
2013-09-24 6:33 ` Heiko Schocher
0 siblings, 1 reply; 6+ messages in thread
From: Jens Scharsig @ 2013-09-23 13:50 UTC (permalink / raw)
To: u-boot
Hello,
I have a access violation problem with i2c_reloc_fixup on coldfire
m68k systems.
I found out, the i2c_reloc_fixup tries to relocate the adapter itself,
but at this time i2c_adap_p is already relocated.
Can anybody confirm this?
I think also m68k, backfin and nds32 systems are affected
regards
Jens
---
diff --git a/drivers/i2c/i2c_core.c b/drivers/i2c/i2c_core.c
index d1072e8..bb5d4db 100644
--- a/drivers/i2c/i2c_core.c
+++ b/drivers/i2c/i2c_core.c
@@ -53,10 +53,6 @@ void i2c_reloc_fixup(void)
return;
for (i = 0; i < max; i++) {
- /* adapter itself */
- addr = (unsigned long)i2c_adap_p;
- addr += gd->reloc_off;
- i2c_adap_p = (struct i2c_adapter *)addr;
/* i2c_init() */
addr = (unsigned long)i2c_adap_p->init;
addr += gd->reloc_off;
^ permalink raw reply related [flat|nested] 6+ messages in thread* [U-Boot] [RFC] i2c_reloc_fixup fails on m68k
2013-09-23 13:50 [U-Boot] [RFC] i2c_reloc_fixup fails on m68k Jens Scharsig
@ 2013-09-24 6:33 ` Heiko Schocher
2013-09-24 7:41 ` Jens Scharsig
2013-10-14 17:40 ` Mike Frysinger
0 siblings, 2 replies; 6+ messages in thread
From: Heiko Schocher @ 2013-09-24 6:33 UTC (permalink / raw)
To: u-boot
Hello Jens,
Am 23.09.2013 15:50, schrieb Jens Scharsig:
> Hello,
>
> I have a access violation problem with i2c_reloc_fixup on coldfire
> m68k systems.
>
> I found out, the i2c_reloc_fixup tries to relocate the adapter itself,
> but at this time i2c_adap_p is already relocated.
Which toolchain?
> Can anybody confirm this?
Added Mike Frysinger, Sonic Zhang (for blackfin) Jason Jin (for m68k)
and Macpaul Lin (for nds32) to Cc ...
> I think also m68k, backfin and nds32 systems are affected
Sorry, I have no such system ... maybe you are the first who stepped
in it ...
> ---
> diff --git a/drivers/i2c/i2c_core.c b/drivers/i2c/i2c_core.c
> index d1072e8..bb5d4db 100644
> --- a/drivers/i2c/i2c_core.c
> +++ b/drivers/i2c/i2c_core.c
> @@ -53,10 +53,6 @@ void i2c_reloc_fixup(void)
> return;
>
> for (i = 0; i< max; i++) {
> - /* adapter itself */
> - addr = (unsigned long)i2c_adap_p;
> - addr += gd->reloc_off;
> - i2c_adap_p = (struct i2c_adapter *)addr;
> /* i2c_init() */
> addr = (unsigned long)i2c_adap_p->init;
> addr += gd->reloc_off;
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [RFC] i2c_reloc_fixup fails on m68k
2013-09-24 6:33 ` Heiko Schocher
@ 2013-09-24 7:41 ` Jens Scharsig
2013-10-14 5:51 ` Heiko Schocher
2013-10-14 17:40 ` Mike Frysinger
1 sibling, 1 reply; 6+ messages in thread
From: Jens Scharsig @ 2013-09-24 7:41 UTC (permalink / raw)
To: u-boot
Hello Heiko,
> Hello Jens,
>> I have a access violation problem with i2c_reloc_fixup on coldfire
>> m68k systems.
>>
>> I found out, the i2c_reloc_fixup tries to relocate the adapter itself,
>> but at this time i2c_adap_p is already relocated.
>
> Which toolchain?
m68k-elf-gcc (Sourcery CodeBench Lite 2011.09-21) 4.6.1
Copyright (C) 2011 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
>
>> Can anybody confirm this?
>
> Added Mike Frysinger, Sonic Zhang (for blackfin) Jason Jin (for m68k)
> and Macpaul Lin (for nds32) to Cc ...
>
>> I think also m68k, backfin and nds32 systems are affected
>
> Sorry, I have no such system ... maybe you are the first who stepped
> in it ...
I have only a m68k system, but only this tree arch's call i2c_reloc_fixup
in this way.
regards
Jens
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [RFC] i2c_reloc_fixup fails on m68k
2013-09-24 7:41 ` Jens Scharsig
@ 2013-10-14 5:51 ` Heiko Schocher
2013-10-14 7:50 ` Jens Scharsig
0 siblings, 1 reply; 6+ messages in thread
From: Heiko Schocher @ 2013-10-14 5:51 UTC (permalink / raw)
To: u-boot
Hello Jens,
Am 24.09.2013 09:41, schrieb Jens Scharsig:
> Hello Heiko,
>> Hello Jens,
>>> I have a access violation problem with i2c_reloc_fixup on coldfire
>>> m68k systems.
>>>
>>> I found out, the i2c_reloc_fixup tries to relocate the adapter itself,
>>> but at this time i2c_adap_p is already relocated.
>>
>> Which toolchain?
>
> m68k-elf-gcc (Sourcery CodeBench Lite 2011.09-21) 4.6.1
> Copyright (C) 2011 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions. There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
>
>>
>>> Can anybody confirm this?
>>
>> Added Mike Frysinger, Sonic Zhang (for blackfin) Jason Jin (for m68k)
>> and Macpaul Lin (for nds32) to Cc ...
>>
>>> I think also m68k, backfin and nds32 systems are affected
>>
>> Sorry, I have no such system ... maybe you are the first who stepped
>> in it ...
>
> I have only a m68k system, but only this tree arch's call i2c_reloc_fixup
> in this way.
Any news here?
@Jens: I want to add this patch in the new merge window, could you send
a correct patch please, thanks!
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [RFC] i2c_reloc_fixup fails on m68k
2013-10-14 5:51 ` Heiko Schocher
@ 2013-10-14 7:50 ` Jens Scharsig
0 siblings, 0 replies; 6+ messages in thread
From: Jens Scharsig @ 2013-10-14 7:50 UTC (permalink / raw)
To: u-boot
Hello Heiko,
Am 2013-10-14 07:51, schrieb Heiko Schocher:
> Hello Jens,
>
> Am 24.09.2013 09:41, schrieb Jens Scharsig:
>> Hello Heiko,
>>> Hello Jens,
>>>> I have a access violation problem with i2c_reloc_fixup on coldfire
>>>> m68k systems.
>>>>
>>>> I found out, the i2c_reloc_fixup tries to relocate the adapter itself,
>>>> but at this time i2c_adap_p is already relocated.
>>>
>>> Which toolchain?
>>
>> m68k-elf-gcc (Sourcery CodeBench Lite 2011.09-21) 4.6.1
>> Copyright (C) 2011 Free Software Foundation, Inc.
>> This is free software; see the source for copying conditions. There is NO
>> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
>>
>>>
>>>> Can anybody confirm this?
>>>
>>> Added Mike Frysinger, Sonic Zhang (for blackfin) Jason Jin (for m68k)
>>> and Macpaul Lin (for nds32) to Cc ...
>>>
>>>> I think also m68k, backfin and nds32 systems are affected
>>>
>>> Sorry, I have no such system ... maybe you are the first who stepped
>>> in it ...
>>
>> I have only a m68k system, but only this tree arch's call i2c_reloc_fixup
>> in this way.
>
> Any news here?
No, silence anywhere
>
> @Jens: I want to add this patch in the new merge window, could you send
> a correct patch please, thanks!
I will do this soon.
Regards Jens
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [RFC] i2c_reloc_fixup fails on m68k
2013-09-24 6:33 ` Heiko Schocher
2013-09-24 7:41 ` Jens Scharsig
@ 2013-10-14 17:40 ` Mike Frysinger
1 sibling, 0 replies; 6+ messages in thread
From: Mike Frysinger @ 2013-10-14 17:40 UTC (permalink / raw)
To: u-boot
On Tuesday 24 September 2013 02:33:55 Heiko Schocher wrote:
> Am 23.09.2013 15:50, schrieb Jens Scharsig:
> > Hello,
> >
> > I have a access violation problem with i2c_reloc_fixup on coldfire
> > m68k systems.
> >
> > I found out, the i2c_reloc_fixup tries to relocate the adapter itself,
> > but at this time i2c_adap_p is already relocated.
>
> Which toolchain?
>
> > Can anybody confirm this?
>
> Added Mike Frysinger, Sonic Zhang (for blackfin) Jason Jin (for m68k)
> and Macpaul Lin (for nds32) to Cc ...
>
> > I think also m68k, backfin and nds32 systems are affected
>
> Sorry, I have no such system ... maybe you are the first who stepped
> in it ...
Blackfin doesn't do self-relocation like that, so we don't care :)
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131014/dbe9d9a2/attachment.pgp>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-10-14 17:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-23 13:50 [U-Boot] [RFC] i2c_reloc_fixup fails on m68k Jens Scharsig
2013-09-24 6:33 ` Heiko Schocher
2013-09-24 7:41 ` Jens Scharsig
2013-10-14 5:51 ` Heiko Schocher
2013-10-14 7:50 ` Jens Scharsig
2013-10-14 17:40 ` Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox