[U-Boot] [PATCH v4 2/2] arm:goni:dfu Add support for DFU at GONI target

Przemyslaw Marczak
2013-10-15T19:23:05Z

Hello Mateusz,

On 10/14/2013 06:56 PM, Mateusz Zalega wrote:
> From: Arkadiusz Wlodarczyk <a.wlodarczyk@samsung.com>
>
> Proper adjustment for supporting DFU at GONI target has been made.
> The s5p_goni.h file has been updated. Moreover the code for low level
> USB initialization has been added to GONI board code.
>
> The malloc pool has been enlarged in order to support larger buffer
> sizes needed by DFU implementation.
>
> Change-Id: I1b4953368176e8a7588abb0da37de6321f835698
> Signed-off-by: Arkadiusz Wlodarczyk <a.wlodarczyk@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> Signed-off-by: Mateusz Zalega <m.zalega@samsung.com>
> Tested-by: Arkadiusz Wlodarczyk <a.wlodarczyk@samsung.com>
> Tested-by: Mateusz Zalega <m.zalega@samsung.com>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> ---
> Changes since v3:
> - adjusted to match recently accepted USB patches
> ---

> +int board_usb_init(int index, enum board_usb_init_type init)
> +{
> + debug("USB_udc_probe\n");
> + s3c_udc_probe(&s5pc110_otg_data);
> + return 0;
> +}
> +#endif
> +

----- starting from this line of your patch

> +#ifdef CONFIG_USB_GADGET_MASS_STORAGE
> +static int ums_read_sector(struct ums_device *ums_dev,
> + ulong start, lbaint_t blkcnt, void *buf)

----- with all these lines inside...

> + ums_board.ums_dev.mmc = mmc;
> + ums_board.ums_dev.dev_num = dev_num;
> + ums_board.ums_dev.offset = offset;
> + ums_board.ums_dev.part_size = part_size;
> +
> + return &ums_board;
> +}
> +
> #endif

----- end this line

Will be not needed, because I would like to move ums initialization code
to Samsung common directory.
Could you wait with this patch please or just don't enable this feature
on goni at this time? Other way I have to remove those lines in my patch
set which I'm gonna send tomorrow.

After my ums refactoring patch set this two below lines will be enought
to enable UMS on goni without ums init code and only with board usb init.

> +#define CONFIG_CMD_USB_MASS_STORAGE
> +#define CONFIG_USB_GADGET_MASS_STORAGE
>
> #endif /* __CONFIG_H */
>

Thank you,

--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com