From mboxrd@z Thu Jan 1 00:00:00 1970 From: Przemyslaw Marczak Date: Tue, 15 Oct 2013 22:18:15 +0200 Subject: [U-Boot] [PATCH v2] mmc: sdhci: Avoid commands errors by simple timeout adaptation. In-Reply-To: <1381248729-21470-1-git-send-email-p.marczak@samsung.com> References: <1380629761-16502-1-git-send-email-p.marczak@samsung.com> <1381248729-21470-1-git-send-email-p.marczak@samsung.com> Message-ID: <525DA307.7060305@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Pantelis, Could you look at this patch, please? On 10/08/2013 06:12 PM, Przemyslaw Marczak wrote: > Old command timeout value was too small and it caused I/O errors which > led to uncompleted read/write/erase operations and filesystem errors. > Timeout adaptation fixes this issue. > > Changes in sdhci_send_command() function: > - change timeout variable to static > - increase default command timeout to 100 ms > - add definition of max command timeout value, > which can be redefined in each board config file > - wait for card ready state for max defined time > if it doesn't exceed defined maximum or return COMM_ERR > > Once successfully increased timeout value will be used in next function > call. This fix was tested on Goni, Trats, Trats2 boards by testing UMS > on MMC storage. > > Changes v2: > - move global variable cmd_timeout into function sdhci_send_command() > - change condition "==" to ">=" when comparing time with timeout > - print information about timeout increasing and card busy timeout > > Signed-off-by: Przemyslaw Marczak > Cc: Pantelis Antoniou Thank you. -- Przemyslaw Marczak Samsung R&D Institute Poland Samsung Electronics p.marczak at samsung.com