From: Paul Burton <paul.burton@imgtec.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mtd: fix warnings due to 64-bit partition support
Date: Wed, 16 Oct 2013 10:39:07 +0100 [thread overview]
Message-ID: <525E5EBB.70602@imgtec.com> (raw)
In-Reply-To: <525E2D55.20106@denx.de>
On 16/10/13 07:08, Stefan Roese wrote:
> Hi Scott,
>
> On 16.10.2013 00:41, Scott Wood wrote:
>> commit 39ac34473f3c96e77cbe03a49141771ed1639486 ("cmd_mtdparts: use 64
>> bits for flash size, partition size & offset") introduced warnings
>> in a couple places due to printf formats or pointer casting.
>>
>> This patch fixes the warnings pointed out here:
>> http://lists.denx.de/pipermail/u-boot/2013-October/164981.html
>>
>> Signed-off-by: Scott Wood <scottwood@freescale.com>
>> Cc: York Sun <yorksun@freescale.com>
>> Cc: Stefan Roese <sr@denx.de>
>> Cc: Paul Burton <paul.burton@imgtec.com>
>> Cc: Tom Rini <trini@ti.com>
>
> Acked-by: Stefan Roese <sr@denx.de>
>
>> ---
>> Alternatively, given the imminent release, perhaps all but the first
>> patch of my recent NAND pull request should be reverted. The first
>> patch was a regression fix, but on a second look the remaining patches
>> look more like enabling a new feature (and I didn't look too closely at
>> the ubi patches because Stefan had acked them and asked me to apply;
>> patch 4 is clearly not a bugfix).
>
> Yes. But the first version of this patchset was posted before the merge
> window was closed (on the 6th of August). So they should be integrated
> in this release. That was my reasoning.
>
> Thanks,
> Stefan
>
Thanks for catching & fixing this guys :)
I'll make sure to build all boards when touching non-board-specific code
in future!
Paul
prev parent reply other threads:[~2013-10-16 9:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 22:41 [U-Boot] [PATCH] mtd: fix warnings due to 64-bit partition support Scott Wood
2013-10-16 0:45 ` [U-Boot] " Tom Rini
2013-10-16 6:08 ` [U-Boot] [PATCH] " Stefan Roese
2013-10-16 9:39 ` Paul Burton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525E5EBB.70602@imgtec.com \
--to=paul.burton@imgtec.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox