From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Thu, 17 Oct 2013 08:29:47 +0200 Subject: [U-Boot] [U-Boot, 1/3, v4] exynos: i2c: Fix i2c driver to handle NACKs properly In-Reply-To: <1381833103-26223-1-git-send-email-ch.naveen@samsung.com> References: <1381833103-26223-1-git-send-email-ch.naveen@samsung.com> Message-ID: <525F83DB.4060309@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Naveen, Am 15.10.2013 12:31, schrieb Naveen Krishna Ch: > The Exynos5 i2c driver does not handle NACKs properly. This change: > > - fixes the NACK processing problem (do not continue transaction if > address cycle was NACKed) > > - eliminates a fair amount of duplicate code > > Signed-off-by: Vadim Bendebury > Reviewed-by: Simon Glass > Signed-off-by: Naveen Krishna Chatradhi > > --- > Changes since v1: > Fixed complilation warning in function i2c_init() > > Changes since v2: > None > > Changes since v3: > None; ran # ./MAKEALL -v samsung > > drivers/i2c/s3c24x0_i2c.c | 214 +++++++++++++++++++-------------------------- > 1 file changed, 90 insertions(+), 124 deletions(-) Applied to u-boot-i2c.git Thanks! bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany