From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Thu, 17 Oct 2013 09:37:27 +0200 Subject: [U-Boot] [PATCH 3/3] sh: ecovec: Update to new I2C framework In-Reply-To: <1381994312-10728-3-git-send-email-nobuhiro.iwamatsu.yj@renesas.com> References: <1381994312-10728-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com> <1381994312-10728-3-git-send-email-nobuhiro.iwamatsu.yj@renesas.com> Message-ID: <525F93B7.4030002@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Nobuhiro, Am 17.10.2013 09:18, schrieb Nobuhiro Iwamatsu: > Ecovec uses sh_i2c driver. sh_i2c driver updated to new I2C framwork. > This updates ecovec to this change. > > Signed-off-by: Nobuhiro Iwamatsu > --- > board/renesas/ecovec/ecovec.c | 4 ++-- > include/configs/ecovec.h | 15 +++++++-------- > 2 files changed, 9 insertions(+), 10 deletions(-) Could you sqash this patch into http://patchwork.ozlabs.org/patch/284106 so we get no problems with "git bisect". Beside of that only one comment: > diff --git a/board/renesas/ecovec/ecovec.c b/board/renesas/ecovec/ecovec.c > index e2d365a..4289d2d 100644 > --- a/board/renesas/ecovec/ecovec.c > +++ b/board/renesas/ecovec/ecovec.c > @@ -57,8 +57,8 @@ int board_late_init(void) > > outl(inl(MSTPCR2)& ~0x10000000, MSTPCR2); > > - i2c_init(CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE); > - i2c_set_bus_num(CONFIG_SYS_I2C_MODULE); /* Use I2C 1 */ > + i2c_init(CONFIG_SYS_I2C_SH_SPEED1, CONFIG_SYS_I2C_SLAVE); > + i2c_set_bus_num(1); /* Use I2C 1 */ same comment as for your patch for the kzm9g board, remove i2c_init() call, as it is no longer necessary, thanks! bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany