From: Ludwig Zenz <lzenz@dh-electronics.com>
To: u-boot@lists.denx.de
Subject: AW: [PATCH 03/16] dh_imx6: Switch to full DM-aware
Date: Thu, 25 Jun 2020 14:52:58 +0000 [thread overview]
Message-ID: <52687cf7a2e047a58530d2f2330e1e37@dh-electronics.com> (raw)
In-Reply-To: <20200622123219.GC27801@bill-the-cat>
On 22/06/20 9:38 AM, Tom Rini wrote:
> On Mon, Jun 22, 2020 at 09:38:36AM +0000, Ludwig Zenz wrote:
>
>> On 6/13/20 3:55 PM, Jagan Teki wrote:
>> > Enable DM_SPI/DM_SPI_FLASH with a related config option.
>> >
>> > Build fine, but not tested.
>>
>> Hello,
>>
>> due to memory limitations in the SRAM of the i.MX6S in SPL we have not used the device tree. Have the restrictions been removed in the meantime? We need a single binary for the i.MX6 q/d/dl/s variants of our system on module.
>>
>> I think this patch breaks the board support for our module.
>
> I _think_ i.MX is making use of the generic hooks to cause build time failures when we grow too large. And we have addressed some, but not all of the concerns about DM size. Can you please test this patch? If it doesn't work doing:
>
>> > diff --git a/include/configs/dh_imx6.h b/include/configs/dh_imx6.h
>> > index 5bfdf4044b..5fb84f72a2 100644
>> > --- a/include/configs/dh_imx6.h
>> > +++ b/include/configs/dh_imx6.h
>> > @@ -53,12 +53,6 @@
>> > /* SATA Configs */
>> > #define CONFIG_LBA48
>> >
>> > -/* SPI Flash Configs */
>> > -#if defined(CONFIG_SPL_BUILD)
>> > -#undef CONFIG_DM_SPI
>> > -#undef CONFIG_DM_SPI_FLASH
>> > -#endif
>
> is still needed as we have a symbol to control DM SPI in SPL directly so the above isn't doing what you imply you want. Thanks!
>
>
With the above patch the board hangs after printing "U-Boot SPL 2020.07-rc5-38776-g922c6d5d009-dirty (Jun 25 2020 - 16:34:23 +0200)".
Through some debugging i found the board hangs on calling gpio_request() in dhcom_get_ddr3_code().
Just for testing I skipped dhcom_get_ddr3_code and hardcoded the DDR3 size. Then I get:
Missing DTB
fdtdec_setup() returned error -1
### ERROR ### Please RESET the board ###
Unfortunately I have not found out how the SPL should load the devicetree. Can you give me a hint for this?
regards,
Ludwig
next prev parent reply other threads:[~2020-06-25 14:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 9:38 [PATCH 03/16] dh_imx6: Switch to full DM-aware Ludwig Zenz
2020-06-22 12:32 ` Tom Rini
2020-06-25 14:52 ` Ludwig Zenz [this message]
2020-06-25 17:21 ` Tom Rini
2020-06-25 17:22 ` Simon Glass
2020-07-08 13:06 ` Jagan Teki
2020-07-10 10:31 ` AW: " Ludwig Zenz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52687cf7a2e047a58530d2f2330e1e37@dh-electronics.com \
--to=lzenz@dh-electronics.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox