From: Gabor Juhos <juhosg@openwrt.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 07/15] qemu-malta: rename to just "malta"
Date: Thu, 24 Oct 2013 14:06:33 +0200 [thread overview]
Message-ID: <52690D49.7080602@openwrt.org> (raw)
In-Reply-To: <5268FC7E.8030702@imgtec.com>
2013.10.24. 12:54 keltez?ssel, Paul Burton ?rta:
<...>
>> I agree that it is related to the rename. However renaming the
>> mips_boot_qemu_malta constant is a simple cleanup which can be done in a
>> preceding patch. The same is true for the CONFIG_QEMU_MALTA->CONFIG_MALTA
>> conversion.
>>
>> In general, renaming a file and altering that within the same patch makes the
>> review harder.
>>
>> -Gabor
>>
>>
>
> And for more complex changes I might agree, but only a single file is both
> renamed and modified by this patch: include/configs/qemu-malta.h =>
> include/configs/malta.h. Only a single line is modified within that file,
> changing CONFIG_QEMU_MALTA to CONFIG_MALTA. I don't think it's very difficult to
> understand and I think splitting it would be overkill. So if Daniel tells me (v3
> of) this patch isn't getting in as-is then I'll split it, but short of that I'm
> not changing it.
I don't say that it is hard to understand that. Simply the first two version of
the patch introduced a regression on older qemu version due to the missing
change in mips32/start.S, and it took some time to me to figure out why a rename
patch causes such thing. If it would have been a separate change, it would have
been obvious.
-Gabor
next prev parent reply other threads:[~2013-10-24 12:06 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 10:07 [U-Boot] [PATCH 00/15] MIPS Malta board support Paul Burton
2013-10-23 10:07 ` [U-Boot] [PATCH 01/15] mips32: detect L1 cache sizes if they're not defined Paul Burton
2013-10-23 10:07 ` [U-Boot] [PATCH 02/15] pcnet: code style cleanup Paul Burton
2013-10-23 10:07 ` [U-Boot] [PATCH 03/15] pcnet: s/le16_to_cpu/cpu_to_le16/ in pcnet_send Paul Burton
2013-10-23 10:07 ` [U-Boot] [PATCH 04/15] pcnet: add cache flushing & invalidation Paul Burton
2013-10-23 10:07 ` [U-Boot] [PATCH 05/15] pcnet: enable the NOUFLO feature Paul Burton
2013-10-23 10:07 ` [U-Boot] [PATCH 06/15] pci.h: allow inclusion in assembly source Paul Burton
2013-10-23 10:07 ` [U-Boot] [PATCH 07/15] qemu-malta: rename to just "malta" Paul Burton
2013-10-23 22:50 ` Daniel Schwierzeck
2013-10-24 9:31 ` [U-Boot] [PATCH v2 " Paul Burton
2013-10-24 10:04 ` Gabor Juhos
2013-10-24 10:10 ` Paul Burton
2013-10-24 10:43 ` Gabor Juhos
2013-10-24 10:54 ` Paul Burton
2013-10-24 11:51 ` Daniel Schwierzeck
2013-10-24 12:06 ` Gabor Juhos [this message]
2013-10-24 10:11 ` [U-Boot] [PATCH v3 " Paul Burton
2013-10-23 10:07 ` [U-Boot] [PATCH 08/15] malta: setup super I/O UARTs Paul Burton
2013-10-24 9:32 ` [U-Boot] [PATCH v2 " Paul Burton
2013-10-23 10:07 ` [U-Boot] [PATCH 09/15] malta: support for coreFPGA6 boards Paul Burton
2013-10-23 22:53 ` Daniel Schwierzeck
2013-10-24 9:33 ` [U-Boot] [PATCH v2 " Paul Burton
2013-10-24 12:14 ` Gabor Juhos
2013-10-24 9:47 ` [U-Boot] [PATCH " Paul Burton
2013-10-23 10:08 ` [U-Boot] [PATCH 10/15] malta: display "U-boot" on the LCD screen Paul Burton
2013-10-24 9:34 ` [U-Boot] [PATCH v2 " Paul Burton
2013-10-23 10:08 ` [U-Boot] [PATCH 11/15] malta: enable CONFIG_PCNET_79C973, PCNET_HAS_PROM, CONFIG_CMD_DHCP Paul Burton
2013-10-23 10:08 ` [U-Boot] [PATCH 12/15] malta: remove cache size definitions Paul Burton
2013-10-23 10:08 ` [U-Boot] [PATCH 13/15] malta: disable L2 caches Paul Burton
2013-10-24 9:34 ` [U-Boot] [PATCH v2 " Paul Burton
2013-10-23 10:08 ` [U-Boot] [PATCH 14/15] malta: add script & instructions to flash U-boot Paul Burton
2013-10-23 22:54 ` Daniel Schwierzeck
2013-10-24 9:35 ` [U-Boot] [PATCH v2 " Paul Burton
2013-10-23 10:11 ` [U-Boot] [PATCH 15/15] malta: add myself to maintainers Paul Burton
2013-10-24 9:36 ` [U-Boot] [PATCH v2 " Paul Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52690D49.7080602@openwrt.org \
--to=juhosg@openwrt.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox