* [U-Boot] [PATCH 0/2] compulab: adjustments before porting more boards
@ 2013-09-16 18:49 Igor Grinberg
2013-09-16 18:49 ` [U-Boot] [PATCH 1/2] cm-t35: move the eeprom code to common place Igor Grinberg
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Igor Grinberg @ 2013-09-16 18:49 UTC (permalink / raw)
To: u-boot
Two more adjustments before porting more Compulab boards to mainline U-Boot.
Move the eeprom code which can be used (and is suitable) by multiple Compulab
boards to a common location.
Move the display initialization code which can be used by multiple Compulab
OMAP based boards.
Igor Grinberg (2):
cm-t35: move the eeprom code to common place
cm-t35: move the display code to common place
board/compulab/cm_t35/Makefile | 3 --
board/compulab/cm_t35/cm_t35.c | 7 ++-
board/compulab/common/Makefile | 36 +++++++++++++++
board/compulab/{cm_t35 => common}/eeprom.c | 51 ++++++++++++----------
board/compulab/{cm_t35 => common}/eeprom.h | 8 ++--
.../{cm_t35/display.c => common/omap3_display.c} | 0
6 files changed, 70 insertions(+), 35 deletions(-)
create mode 100644 board/compulab/common/Makefile
rename board/compulab/{cm_t35 => common}/eeprom.c (60%)
rename board/compulab/{cm_t35 => common}/eeprom.h (62%)
rename board/compulab/{cm_t35/display.c => common/omap3_display.c} (100%)
--
1.8.1.5
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 1/2] cm-t35: move the eeprom code to common place
2013-09-16 18:49 [U-Boot] [PATCH 0/2] compulab: adjustments before porting more boards Igor Grinberg
@ 2013-09-16 18:49 ` Igor Grinberg
2013-11-04 14:18 ` [U-Boot] [U-Boot, " Tom Rini
2013-09-16 18:49 ` [U-Boot] [PATCH 2/2] cm-t35: move the display " Igor Grinberg
2013-09-30 8:36 ` [U-Boot] [PATCH 0/2] compulab: adjustments before porting more boards Igor Grinberg
2 siblings, 1 reply; 9+ messages in thread
From: Igor Grinberg @ 2013-09-16 18:49 UTC (permalink / raw)
To: u-boot
Compulab boards use the same eeprom code, so move the eeprom related
code to live under board/compulab/common directory.
Also make several adjustments to eeprom functions namespace, so it will
be generic for compulab boards.
Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
Tested-by: Nikita Kiryanov <nikita@compulab.co.il>
---
board/compulab/cm_t35/Makefile | 1 -
board/compulab/cm_t35/cm_t35.c | 7 ++--
board/compulab/common/Makefile | 35 ++++++++++++++++++++
board/compulab/{cm_t35 => common}/eeprom.c | 51 ++++++++++++++++--------------
board/compulab/{cm_t35 => common}/eeprom.h | 8 ++---
5 files changed, 69 insertions(+), 33 deletions(-)
create mode 100644 board/compulab/common/Makefile
rename board/compulab/{cm_t35 => common}/eeprom.c (60%)
rename board/compulab/{cm_t35 => common}/eeprom.h (62%)
diff --git a/board/compulab/cm_t35/Makefile b/board/compulab/cm_t35/Makefile
index 6d07947..8b922b3 100644
--- a/board/compulab/cm_t35/Makefile
+++ b/board/compulab/cm_t35/Makefile
@@ -11,7 +11,6 @@ include $(TOPDIR)/config.mk
LIB = $(obj)lib$(BOARD).o
-COBJS-$(CONFIG_DRIVER_OMAP34XX_I2C) += eeprom.o
COBJS-$(CONFIG_LCD) += display.o
COBJS := cm_t35.o leds.o $(COBJS-y)
diff --git a/board/compulab/cm_t35/cm_t35.c b/board/compulab/cm_t35/cm_t35.c
index 3caa5be..a6d4aba 100644
--- a/board/compulab/cm_t35/cm_t35.c
+++ b/board/compulab/cm_t35/cm_t35.c
@@ -33,7 +33,7 @@
#include <asm/ehci-omap.h>
#include <asm/gpio.h>
-#include "eeprom.h"
+#include "../common/eeprom.h"
DECLARE_GLOBAL_DATA_PTR;
@@ -160,7 +160,7 @@ static u32 cm_t3x_rev;
u32 get_board_rev(void)
{
if (!cm_t3x_rev)
- cm_t3x_rev = cm_t3x_eeprom_get_board_rev();
+ cm_t3x_rev = cl_eeprom_get_board_rev();
return cm_t3x_rev;
};
@@ -509,7 +509,7 @@ static int handle_mac_address(void)
if (rc)
return 0;
- rc = cm_t3x_eeprom_read_mac_addr(enetaddr);
+ rc = cl_eeprom_read_mac_addr(enetaddr);
if (rc)
return rc;
@@ -598,5 +598,4 @@ int ehci_hcd_stop(void)
{
return omap_ehci_hcd_stop();
}
-
#endif /* CONFIG_USB_EHCI_OMAP */
diff --git a/board/compulab/common/Makefile b/board/compulab/common/Makefile
new file mode 100644
index 0000000..ec2e510
--- /dev/null
+++ b/board/compulab/common/Makefile
@@ -0,0 +1,35 @@
+#
+# (C) Copyright 2011 - 2013 CompuLab, Ltd. <www.compulab.co.il>
+#
+# Author: Igor Grinberg <grinberg@compulab.co.il>
+#
+# SPDX-License-Identifier: GPL-2.0+
+#
+
+include $(TOPDIR)/config.mk
+
+ifneq ($(OBJTREE),$(SRCTREE))
+$(shell mkdir -p $(obj)board/$(VENDOR)/common)
+endif
+
+LIB = $(obj)lib$(VENDOR).o
+
+COBJS-$(CONFIG_DRIVER_OMAP34XX_I2C) += eeprom.o
+
+COBJS := $(COBJS-y)
+SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c)
+OBJS := $(addprefix $(obj),$(COBJS))
+SOBJS := $(addprefix $(obj),$(SOBJS))
+
+all: $(LIB)
+
+$(LIB): $(obj).depend $(OBJS) $(SOBJS)
+ $(call cmd_link_o_target, $(OBJS) $(SOBJS))
+
+#########################################################################
+# This is for $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#########################################################################
diff --git a/board/compulab/cm_t35/eeprom.c b/board/compulab/common/eeprom.c
similarity index 60%
rename from board/compulab/cm_t35/eeprom.c
rename to board/compulab/common/eeprom.c
index df91acd..5aa3dbd 100644
--- a/board/compulab/cm_t35/eeprom.c
+++ b/board/compulab/common/eeprom.c
@@ -22,30 +22,30 @@
#define LAYOUT_INVALID 0
#define LAYOUT_LEGACY 0xff
-static int eeprom_layout; /* Implicitly LAYOUT_INVALID */
+static int cl_eeprom_layout; /* Implicitly LAYOUT_INVALID */
-static int cm_t3x_eeprom_read(uint offset, uchar *buf, int len)
+static int cl_eeprom_read(uint offset, uchar *buf, int len)
{
return i2c_read(CONFIG_SYS_I2C_EEPROM_ADDR, offset,
CONFIG_SYS_I2C_EEPROM_ADDR_LEN, buf, len);
}
-static int eeprom_setup_layout(void)
+static int cl_eeprom_setup_layout(void)
{
int res;
- if (eeprom_layout != LAYOUT_INVALID)
+ if (cl_eeprom_layout != LAYOUT_INVALID)
return 0;
- res = cm_t3x_eeprom_read(EEPROM_LAYOUT_VER_OFFSET,
- (uchar *)&eeprom_layout, 1);
+ res = cl_eeprom_read(EEPROM_LAYOUT_VER_OFFSET,
+ (uchar *)&cl_eeprom_layout, 1);
if (res) {
- eeprom_layout = LAYOUT_INVALID;
+ cl_eeprom_layout = LAYOUT_INVALID;
return res;
}
- if (eeprom_layout == 0 || eeprom_layout >= 0x20)
- eeprom_layout = LAYOUT_LEGACY;
+ if (cl_eeprom_layout == 0 || cl_eeprom_layout >= 0x20)
+ cl_eeprom_layout = LAYOUT_LEGACY;
return 0;
}
@@ -56,12 +56,14 @@ void get_board_serial(struct tag_serialnr *serialnr)
uint offset;
memset(serialnr, 0, sizeof(*serialnr));
- if (eeprom_setup_layout())
+
+ if (cl_eeprom_setup_layout())
return;
- offset = (eeprom_layout != LAYOUT_LEGACY) ?
- BOARD_SERIAL_OFFSET : BOARD_SERIAL_OFFSET_LEGACY;
- if (cm_t3x_eeprom_read(offset, (uchar *)serial, 8))
+ offset = (cl_eeprom_layout != LAYOUT_LEGACY) ?
+ BOARD_SERIAL_OFFSET : BOARD_SERIAL_OFFSET_LEGACY;
+
+ if (cl_eeprom_read(offset, (uchar *)serial, 8))
return;
if (serial[0] != 0xffffffff && serial[1] != 0xffffffff) {
@@ -71,45 +73,46 @@ void get_board_serial(struct tag_serialnr *serialnr)
}
/*
- * Routine: cm_t3x_eeprom_read_mac_addr
+ * Routine: cl_eeprom_read_mac_addr
* Description: read mac address and store it in buf.
*/
-int cm_t3x_eeprom_read_mac_addr(uchar *buf)
+int cl_eeprom_read_mac_addr(uchar *buf)
{
uint offset;
- if (eeprom_setup_layout())
+ if (cl_eeprom_setup_layout())
return 0;
- offset = (eeprom_layout != LAYOUT_LEGACY) ?
+ offset = (cl_eeprom_layout != LAYOUT_LEGACY) ?
MAC_ADDR_OFFSET : MAC_ADDR_OFFSET_LEGACY;
- return cm_t3x_eeprom_read(offset, buf, 6);
+
+ return cl_eeprom_read(offset, buf, 6);
}
/*
- * Routine: cm_t3x_eeprom_get_board_rev
+ * Routine: cl_eeprom_get_board_rev
* Description: read system revision from eeprom
*/
-u32 cm_t3x_eeprom_get_board_rev(void)
+u32 cl_eeprom_get_board_rev(void)
{
u32 rev = 0;
char str[5]; /* Legacy representation can contain at most 4 digits */
uint offset = BOARD_REV_OFFSET_LEGACY;
- if (eeprom_setup_layout())
+ if (cl_eeprom_setup_layout())
return 0;
- if (eeprom_layout != LAYOUT_LEGACY)
+ if (cl_eeprom_layout != LAYOUT_LEGACY)
offset = BOARD_REV_OFFSET;
- if (cm_t3x_eeprom_read(offset, (uchar *)&rev, BOARD_REV_SIZE))
+ if (cl_eeprom_read(offset, (uchar *)&rev, BOARD_REV_SIZE))
return 0;
/*
* Convert legacy syntactic representation to semantic
* representation. i.e. for rev 1.00: 0x100 --> 0x64
*/
- if (eeprom_layout == LAYOUT_LEGACY) {
+ if (cl_eeprom_layout == LAYOUT_LEGACY) {
sprintf(str, "%x", rev);
rev = simple_strtoul(str, NULL, 10);
}
diff --git a/board/compulab/cm_t35/eeprom.h b/board/compulab/common/eeprom.h
similarity index 62%
rename from board/compulab/cm_t35/eeprom.h
rename to board/compulab/common/eeprom.h
index 02ffbb1..cf8c302 100644
--- a/board/compulab/cm_t35/eeprom.h
+++ b/board/compulab/common/eeprom.h
@@ -11,14 +11,14 @@
#define _EEPROM_
#ifdef CONFIG_DRIVER_OMAP34XX_I2C
-int cm_t3x_eeprom_read_mac_addr(uchar *buf);
-u32 cm_t3x_eeprom_get_board_rev(void);
+int cl_eeprom_read_mac_addr(uchar *buf);
+u32 cl_eeprom_get_board_rev(void);
#else
-static inline int cm_t3x_eeprom_read_mac_addr(uchar *buf)
+static inline int cl_eeprom_read_mac_addr(uchar *buf)
{
return 1;
}
-static inline u32 cm_t3x_eeprom_get_board_rev(void)
+static inline u32 cl_eeprom_get_board_rev(void)
{
return 0;
}
--
1.8.1.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 2/2] cm-t35: move the display code to common place
2013-09-16 18:49 [U-Boot] [PATCH 0/2] compulab: adjustments before porting more boards Igor Grinberg
2013-09-16 18:49 ` [U-Boot] [PATCH 1/2] cm-t35: move the eeprom code to common place Igor Grinberg
@ 2013-09-16 18:49 ` Igor Grinberg
2013-11-04 14:18 ` [U-Boot] [U-Boot, " Tom Rini
2013-09-30 8:36 ` [U-Boot] [PATCH 0/2] compulab: adjustments before porting more boards Igor Grinberg
2 siblings, 1 reply; 9+ messages in thread
From: Igor Grinberg @ 2013-09-16 18:49 UTC (permalink / raw)
To: u-boot
Compulab OMAP3 boards use the same display initialization code.
Move the display initialization code to live under board/compulab/common
directory.
Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
Tested-by: Nikita Kiryanov <nikita@compulab.co.il>
---
board/compulab/cm_t35/Makefile | 2 --
board/compulab/common/Makefile | 1 +
board/compulab/{cm_t35/display.c => common/omap3_display.c} | 0
3 files changed, 1 insertion(+), 2 deletions(-)
rename board/compulab/{cm_t35/display.c => common/omap3_display.c} (100%)
diff --git a/board/compulab/cm_t35/Makefile b/board/compulab/cm_t35/Makefile
index 8b922b3..213423e 100644
--- a/board/compulab/cm_t35/Makefile
+++ b/board/compulab/cm_t35/Makefile
@@ -11,8 +11,6 @@ include $(TOPDIR)/config.mk
LIB = $(obj)lib$(BOARD).o
-COBJS-$(CONFIG_LCD) += display.o
-
COBJS := cm_t35.o leds.o $(COBJS-y)
SRCS := $(COBJS:.o=.c)
diff --git a/board/compulab/common/Makefile b/board/compulab/common/Makefile
index ec2e510..b399c8f 100644
--- a/board/compulab/common/Makefile
+++ b/board/compulab/common/Makefile
@@ -15,6 +15,7 @@ endif
LIB = $(obj)lib$(VENDOR).o
COBJS-$(CONFIG_DRIVER_OMAP34XX_I2C) += eeprom.o
+COBJS-$(CONFIG_LCD) += omap3_display.o
COBJS := $(COBJS-y)
SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c)
diff --git a/board/compulab/cm_t35/display.c b/board/compulab/common/omap3_display.c
similarity index 100%
rename from board/compulab/cm_t35/display.c
rename to board/compulab/common/omap3_display.c
--
1.8.1.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 0/2] compulab: adjustments before porting more boards
2013-09-16 18:49 [U-Boot] [PATCH 0/2] compulab: adjustments before porting more boards Igor Grinberg
2013-09-16 18:49 ` [U-Boot] [PATCH 1/2] cm-t35: move the eeprom code to common place Igor Grinberg
2013-09-16 18:49 ` [U-Boot] [PATCH 2/2] cm-t35: move the display " Igor Grinberg
@ 2013-09-30 8:36 ` Igor Grinberg
2013-10-02 12:53 ` Tom Rini
2 siblings, 1 reply; 9+ messages in thread
From: Igor Grinberg @ 2013-09-30 8:36 UTC (permalink / raw)
To: u-boot
ping!
On 09/16/13 21:49, Igor Grinberg wrote:
> Two more adjustments before porting more Compulab boards to mainline U-Boot.
> Move the eeprom code which can be used (and is suitable) by multiple Compulab
> boards to a common location.
> Move the display initialization code which can be used by multiple Compulab
> OMAP based boards.
>
> Igor Grinberg (2):
> cm-t35: move the eeprom code to common place
> cm-t35: move the display code to common place
>
> board/compulab/cm_t35/Makefile | 3 --
> board/compulab/cm_t35/cm_t35.c | 7 ++-
> board/compulab/common/Makefile | 36 +++++++++++++++
> board/compulab/{cm_t35 => common}/eeprom.c | 51 ++++++++++++----------
> board/compulab/{cm_t35 => common}/eeprom.h | 8 ++--
> .../{cm_t35/display.c => common/omap3_display.c} | 0
> 6 files changed, 70 insertions(+), 35 deletions(-)
> create mode 100644 board/compulab/common/Makefile
> rename board/compulab/{cm_t35 => common}/eeprom.c (60%)
> rename board/compulab/{cm_t35 => common}/eeprom.h (62%)
> rename board/compulab/{cm_t35/display.c => common/omap3_display.c} (100%)
>
--
Regards,
Igor.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 0/2] compulab: adjustments before porting more boards
2013-09-30 8:36 ` [U-Boot] [PATCH 0/2] compulab: adjustments before porting more boards Igor Grinberg
@ 2013-10-02 12:53 ` Tom Rini
2013-10-02 14:02 ` Igor Grinberg
0 siblings, 1 reply; 9+ messages in thread
From: Tom Rini @ 2013-10-02 12:53 UTC (permalink / raw)
To: u-boot
On Mon, Sep 30, 2013 at 11:36:32AM +0300, Igor Grinberg wrote:
> ping!
>
> On 09/16/13 21:49, Igor Grinberg wrote:
> > Two more adjustments before porting more Compulab boards to mainline U-Boot.
> > Move the eeprom code which can be used (and is suitable) by multiple Compulab
> > boards to a common location.
> > Move the display initialization code which can be used by multiple Compulab
> > OMAP based boards.
> >
> > Igor Grinberg (2):
> > cm-t35: move the eeprom code to common place
> > cm-t35: move the display code to common place
> >
> > board/compulab/cm_t35/Makefile | 3 --
> > board/compulab/cm_t35/cm_t35.c | 7 ++-
> > board/compulab/common/Makefile | 36 +++++++++++++++
> > board/compulab/{cm_t35 => common}/eeprom.c | 51 ++++++++++++----------
> > board/compulab/{cm_t35 => common}/eeprom.h | 8 ++--
> > .../{cm_t35/display.c => common/omap3_display.c} | 0
> > 6 files changed, 70 insertions(+), 35 deletions(-)
> > create mode 100644 board/compulab/common/Makefile
> > rename board/compulab/{cm_t35 => common}/eeprom.c (60%)
> > rename board/compulab/{cm_t35 => common}/eeprom.h (62%)
> > rename board/compulab/{cm_t35/display.c => common/omap3_display.c} (100%)
Generally fine, but posted after the merge window so I hadn't picked it
up for u-boot-ti yet, thanks.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131002/902558d2/attachment.pgp>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 0/2] compulab: adjustments before porting more boards
2013-10-02 12:53 ` Tom Rini
@ 2013-10-02 14:02 ` Igor Grinberg
2013-10-27 7:23 ` Igor Grinberg
0 siblings, 1 reply; 9+ messages in thread
From: Igor Grinberg @ 2013-10-02 14:02 UTC (permalink / raw)
To: u-boot
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Tom,
On 10/02/13 15:53, Tom Rini wrote:
> On Mon, Sep 30, 2013 at 11:36:32AM +0300, Igor Grinberg wrote:
>
>> ping!
>>
>> On 09/16/13 21:49, Igor Grinberg wrote:
>>> Two more adjustments before porting more Compulab boards to mainline U-Boot.
>>> Move the eeprom code which can be used (and is suitable) by multiple Compulab
>>> boards to a common location.
>>> Move the display initialization code which can be used by multiple Compulab
>>> OMAP based boards.
>>>
>>> Igor Grinberg (2):
>>> cm-t35: move the eeprom code to common place
>>> cm-t35: move the display code to common place
>>>
>>> board/compulab/cm_t35/Makefile | 3 --
>>> board/compulab/cm_t35/cm_t35.c | 7 ++-
>>> board/compulab/common/Makefile | 36 +++++++++++++++
>>> board/compulab/{cm_t35 => common}/eeprom.c | 51 ++++++++++++----------
>>> board/compulab/{cm_t35 => common}/eeprom.h | 8 ++--
>>> .../{cm_t35/display.c => common/omap3_display.c} | 0
>>> 6 files changed, 70 insertions(+), 35 deletions(-)
>>> create mode 100644 board/compulab/common/Makefile
>>> rename board/compulab/{cm_t35 => common}/eeprom.c (60%)
>>> rename board/compulab/{cm_t35 => common}/eeprom.h (62%)
>>> rename board/compulab/{cm_t35/display.c => common/omap3_display.c} (100%)
>
> Generally fine, but posted after the merge window so I hadn't picked it
> up for u-boot-ti yet, thanks.
No problem, I was actually aiming for v2014.01
(or which ever the next release will be).
I just have more stuff in the queue that depends on the above
and like it to be applied before sending out the next series.
10x!
- --
Regards,
Igor.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)
iQIcBAEBAgAGBQJSTCd2AAoJEBDE8YO64EfaIZEP/j/GwAo79meDOujygMAgRzwW
8bOspDANVO/FcO0OifyD3q06aCFYqsMfcH07ebzlRO6tfmpY3WSiTNTgs68Jwepu
TvsCBL7wps8lH4R6DoCZjpjaZV6khjyZinSfO+E/MV5Zgb9FhS/gyKwJ4rXEIoLT
k9tK3QtGdQHNtWSd0ZMzF711hhZgkUBUx2MsPwDoZsGjYyqBaW9O2dz8IoSf/wSh
jvrVl/tntyoIQIG7r8kIZ9XCoBiBnj/mSwkugp7yXCecJdzh1azUo43oLl4uS7em
CWkZuLDJkB6WGiLoju2DYymIQ2ira6VdHZCLb7DbOvZ7Ja6Uz394zIOLxnqobvCl
l3n2KR7w1HOGBo7lBhC8QPMCeNEQ2skIvamp3lcuPmfucx6cGDJWRZQulX/X7JcS
ktYNLSB927E71x2c6kEBHEDb/E/EyI0/Xr4dBhQTou3A5psUayfkB7uXpObuooHt
XD3SjpMDGf7HNok6MkFxuZdIPgr1UNkrlEf/qZWoHJKuMOEhVbrTjPK8ZbkQ2Ozi
DaT5SqgNghd+nCZ477T1Vg/XzzwNc05tpc8r5dY7YCrKf5WKrTpHJuC62Xc216yA
Rr+9ifYecsnDE0R/tfVojBu8hlBskWuyV13EblkvWON/tXqODRqY3dsMQlV4/2x5
TRjoIgkB5cV17iot7CWT
=c83T
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 0/2] compulab: adjustments before porting more boards
2013-10-02 14:02 ` Igor Grinberg
@ 2013-10-27 7:23 ` Igor Grinberg
0 siblings, 0 replies; 9+ messages in thread
From: Igor Grinberg @ 2013-10-27 7:23 UTC (permalink / raw)
To: u-boot
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Tom,
On 10/02/13 17:02, Igor Grinberg wrote:
> Hi Tom,
>
> On 10/02/13 15:53, Tom Rini wrote:
>> On Mon, Sep 30, 2013 at 11:36:32AM +0300, Igor Grinberg wrote:
>
>>> ping!
>>>
>>> On 09/16/13 21:49, Igor Grinberg wrote:
>>>> Two more adjustments before porting more Compulab boards to mainline U-Boot.
>>>> Move the eeprom code which can be used (and is suitable) by multiple Compulab
>>>> boards to a common location.
>>>> Move the display initialization code which can be used by multiple Compulab
>>>> OMAP based boards.
>>>>
>>>> Igor Grinberg (2):
>>>> cm-t35: move the eeprom code to common place
>>>> cm-t35: move the display code to common place
>>>>
>>>> board/compulab/cm_t35/Makefile | 3 --
>>>> board/compulab/cm_t35/cm_t35.c | 7 ++-
>>>> board/compulab/common/Makefile | 36 +++++++++++++++
>>>> board/compulab/{cm_t35 => common}/eeprom.c | 51 ++++++++++++----------
>>>> board/compulab/{cm_t35 => common}/eeprom.h | 8 ++--
>>>> .../{cm_t35/display.c => common/omap3_display.c} | 0
>>>> 6 files changed, 70 insertions(+), 35 deletions(-)
>>>> create mode 100644 board/compulab/common/Makefile
>>>> rename board/compulab/{cm_t35 => common}/eeprom.c (60%)
>>>> rename board/compulab/{cm_t35 => common}/eeprom.h (62%)
>>>> rename board/compulab/{cm_t35/display.c => common/omap3_display.c} (100%)
>
>> Generally fine, but posted after the merge window so I hadn't picked it
>> up for u-boot-ti yet, thanks.
>
> No problem, I was actually aiming for v2014.01
> (or which ever the next release will be).
>
> I just have more stuff in the queue that depends on the above
> and like it to be applied before sending out the next series.
>
> 10x!
Where is that TI hat of yours?
It's just about time!
- --
Regards,
Igor.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)
iQIcBAEBAgAGBQJSbL9aAAoJEBDE8YO64EfayBIQAI5cAVvD+cOT2KAO6HgkowUl
wQlpAt79C2AMXeFZX9zld9sg3CQhBfvwkyKhhvSMTTl0CYEFUGUZBrt+QEdL5qBo
0zUlM2YcYlICxp5Qsd+/ihLAlqXEgc0jMj4qwT+JEPXwnpj3MrL/WOpr7rGbZfPs
NzFyq64bE95bIk3Qm5l3+QKLSVFwSvyiY9HsyIXQF+ETM/mzXTRGnEdWcehJDGT8
djGiMXSq0TU4r7AaE2ooZoyff75xhDt2qjPl5hNqa82icVmZXyvKOJium/ROmS5H
IcQCqPn6xJHjQNrA1vQt2FK6wJGfOC4EBFAVVRLafGUROVxjLzZ8Xf2dNAsiFUJg
dc43wvM01s3OxOOMa4tPJPwi4b/BUootXZKXMf037WMpwrxW+PZT5Ca0Z/F03q3m
RjuMFGpEJB8YqB+0+B8z4VqEhNUIPrg2McOX25+TmB1bB2Hl5RJXRXOUu16GJBpm
r23/3VIiXQj/j6VgVIbUzvVR/t+oR/QUaJuAf8r8DUeXNZbYcx7uremOjE0YjdJG
px4fgjj4FNCcdHS80iGCsfii7N9VFMfvP92trJFTap199UlJtnFs+NYRO9NLyMu9
QuyMkQc79EK3vN0BK9CZOpXEugODZYqbyLDbKM2/DJBDZBwyb4KCnNUZQJBZfogz
Tv6M0PTxGW47nIoo8RA5
=O+My
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [U-Boot, 1/2] cm-t35: move the eeprom code to common place
2013-09-16 18:49 ` [U-Boot] [PATCH 1/2] cm-t35: move the eeprom code to common place Igor Grinberg
@ 2013-11-04 14:18 ` Tom Rini
0 siblings, 0 replies; 9+ messages in thread
From: Tom Rini @ 2013-11-04 14:18 UTC (permalink / raw)
To: u-boot
On Mon, Sep 16, 2013 at 09:49:58PM +0300, Igor Grinberg wrote:
> Compulab boards use the same eeprom code, so move the eeprom related
> code to live under board/compulab/common directory.
> Also make several adjustments to eeprom functions namespace, so it will
> be generic for compulab boards.
>
> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
> Tested-by: Nikita Kiryanov <nikita@compulab.co.il>
Applied to u-boot-ti/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131104/98da83cc/attachment.pgp>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [U-Boot, 2/2] cm-t35: move the display code to common place
2013-09-16 18:49 ` [U-Boot] [PATCH 2/2] cm-t35: move the display " Igor Grinberg
@ 2013-11-04 14:18 ` Tom Rini
0 siblings, 0 replies; 9+ messages in thread
From: Tom Rini @ 2013-11-04 14:18 UTC (permalink / raw)
To: u-boot
On Mon, Sep 16, 2013 at 09:49:59PM +0300, Igor Grinberg wrote:
> Compulab OMAP3 boards use the same display initialization code.
> Move the display initialization code to live under board/compulab/common
> directory.
>
> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
> Tested-by: Nikita Kiryanov <nikita@compulab.co.il>
Applied to u-boot-ti/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131104/9e8845fc/attachment.pgp>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-11-04 14:18 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-16 18:49 [U-Boot] [PATCH 0/2] compulab: adjustments before porting more boards Igor Grinberg
2013-09-16 18:49 ` [U-Boot] [PATCH 1/2] cm-t35: move the eeprom code to common place Igor Grinberg
2013-11-04 14:18 ` [U-Boot] [U-Boot, " Tom Rini
2013-09-16 18:49 ` [U-Boot] [PATCH 2/2] cm-t35: move the display " Igor Grinberg
2013-11-04 14:18 ` [U-Boot] [U-Boot, " Tom Rini
2013-09-30 8:36 ` [U-Boot] [PATCH 0/2] compulab: adjustments before porting more boards Igor Grinberg
2013-10-02 12:53 ` Tom Rini
2013-10-02 14:02 ` Igor Grinberg
2013-10-27 7:23 ` Igor Grinberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox