public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4] i2c, omap24xx: convert driver to new mutlibus/mutliadapter framework
Date: Sun, 27 Oct 2013 09:30:14 +0200	[thread overview]
Message-ID: <526CC106.2030201@compulab.co.il> (raw)
In-Reply-To: <1382432598-22547-1-git-send-email-hs@denx.de>

Hi Heiko,

On 10/22/13 11:03, Heiko Schocher wrote:
> - add omap24xx driver to new multibus/multiadpater support
> - adapted all config files, which uses this driver
> 
> Tested on the am335x based siemens boards rut, dxr2 and pxm2
> posted here:
> http://patchwork.ozlabs.org/patch/263211/
> 
> Signed-off-by: Heiko Schocher <hs@denx.de>
> Tested-by: Tom Rini <trini@ti.com>
> Cc: Lars Poeschel <poeschel@lemonage.de>
> Cc: Steve Sakoman <sakoman@gmail.com>
> Cc: Thomas Weber <weber@corscience.de>
> Cc: Tom Rix <Tom.Rix@windriver.com>
> Cc: Grazvydas Ignotas <notasas@gmail.com>
> Cc: Enric Balletbo i Serra <eballetbo@iseebcn.com>
> Cc: Luca Ceresoli <luca.ceresoli@comelit.it>
> Cc: Igor Grinberg <grinberg@compulab.co.il>
> Cc: Ilya Yanok <yanok@emcraft.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Pali Roh?r <pali.rohar@gmail.com>
> Cc: Peter Barada <peter.barada@logicpd.com>
> Cc: Nagendra T S  <nagendra@mistralsolutions.com>
> Cc: Michael Jones <michael.jones@matrix-vision.de>
> Cc: Raphael Assenat <raph@8d.com>

[...]

>  board/compulab/cm_t35/Makefile                 |   2 +-
>  board/compulab/cm_t35/cm_t35.c                 |   2 +-
>  board/compulab/cm_t35/eeprom.h                 |   2 +-

[...]

>  include/configs/cm_t35.h                       |   8 +-

[...]

> diff --git a/board/compulab/cm_t35/Makefile b/board/compulab/cm_t35/Makefile
> index 6d07947..9014d2a 100644
> --- a/board/compulab/cm_t35/Makefile
> +++ b/board/compulab/cm_t35/Makefile
> @@ -11,7 +11,7 @@ include $(TOPDIR)/config.mk
>  
>  LIB	= $(obj)lib$(BOARD).o
>  
> -COBJS-$(CONFIG_DRIVER_OMAP34XX_I2C) += eeprom.o
> +COBJS-$(CONFIG_SYS_I2C_OMAP34XX) += eeprom.o
>  COBJS-$(CONFIG_LCD) += display.o
>  
>  COBJS	:= cm_t35.o leds.o $(COBJS-y)
> diff --git a/board/compulab/cm_t35/cm_t35.c b/board/compulab/cm_t35/cm_t35.c
> index 3caa5be..1dd3647 100644
> --- a/board/compulab/cm_t35/cm_t35.c
> +++ b/board/compulab/cm_t35/cm_t35.c
> @@ -470,7 +470,7 @@ static void setup_net_chip_gmpc(void)
>  		&ctrl_base->gpmc_nadv_ale);
>  }
>  
> -#ifdef CONFIG_DRIVER_OMAP34XX_I2C
> +#ifdef CONFIG_SYS_I2C_OMAP34XX
>  /*
>   * Routine: reset_net_chip
>   * Description: reset the Ethernet controller via TPS65930 GPIO
> diff --git a/board/compulab/cm_t35/eeprom.h b/board/compulab/cm_t35/eeprom.h
> index 02ffbb1..a07559d 100644
> --- a/board/compulab/cm_t35/eeprom.h
> +++ b/board/compulab/cm_t35/eeprom.h
> @@ -10,7 +10,7 @@
>  #ifndef _EEPROM_
>  #define _EEPROM_
>  
> -#ifdef CONFIG_DRIVER_OMAP34XX_I2C
> +#ifdef CONFIG_SYS_I2C_OMAP34XX
>  int cm_t3x_eeprom_read_mac_addr(uchar *buf);
>  u32 cm_t3x_eeprom_get_board_rev(void);
>  #else

Please, rebase on top of:
http://patchwork.ozlabs.org/patch/275284/
which should be applied any time soon.

Otherwise,
Acked-by: Igor Grinberg <grinberg@compulab.co.il>

[...]

> diff --git a/include/configs/cm_t35.h b/include/configs/cm_t35.h
> index bc5b66c..c301697 100644
> --- a/include/configs/cm_t35.h
> +++ b/include/configs/cm_t35.h
> @@ -140,10 +140,10 @@
>  #undef CONFIG_CMD_IMLS		/* List all found images	*/
>  
>  #define CONFIG_SYS_NO_FLASH
> -#define CONFIG_HARD_I2C
> -#define CONFIG_SYS_I2C_SPEED		100000
> -#define CONFIG_SYS_I2C_SLAVE		1
> -#define CONFIG_DRIVER_OMAP34XX_I2C
> +#define CONFIG_SYS_I2C
> +#define CONFIG_SYS_OMAP24_I2C_SPEED	100000
> +#define CONFIG_SYS_OMAP24_I2C_SLAVE	1
> +#define CONFIG_SYS_I2C_OMAP34XX
>  #define CONFIG_SYS_I2C_EEPROM_ADDR	0x50
>  #define CONFIG_SYS_I2C_EEPROM_ADDR_LEN	1
>  #define CONFIG_I2C_MULTI_BUS

[...]


-- 
Regards,
Igor.

  reply	other threads:[~2013-10-27  7:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-22  9:03 [U-Boot] [PATCH v4] i2c, omap24xx: convert driver to new mutlibus/mutliadapter framework Heiko Schocher
2013-10-27  7:30 ` Igor Grinberg [this message]
2013-10-28  6:19   ` Heiko Schocher
2013-10-29 11:07     ` Igor Grinberg
2013-10-29 11:30       ` Heiko Schocher
2013-11-04  6:56         ` Heiko Schocher
2013-11-04 13:39           ` Tom Rini
2013-10-28  9:07 ` Stefano Babic
2013-11-13  6:33 ` [U-Boot] [U-Boot, " Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=526CC106.2030201@compulab.co.il \
    --to=grinberg@compulab.co.il \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox