public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Zhang Haijun <b42677@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] esdhc: memset mmc struct before putting into	use
Date: Mon, 28 Oct 2013 10:00:26 +0800	[thread overview]
Message-ID: <526DC53A.1050205@freescale.com> (raw)
In-Reply-To: <OFB7AF4A4B.DA4AB6FA-ON86257C0F.005991C1-86257C0F.005A78F3@rockwellcollins.com>

Thanks. Barnett

:-)
? 2013/10/26 0:28, Ryan Barnett ??:
> Haijun Zhang <Haijun.Zhang@freescale.com> wrote on 10/24/2013 08:54:42 PM:
>
>> struct mmc should be clear to all '0' after malloc to avoid
>> unexpect variable value.
>>
>> Like mmc->has_init = xxx.
>> In this case mmcinfo will believe the card had been initialized before
>> and skip the initialization.
>>
>> Test on P5040 and T4240,
>> Error Log:
>>
>> => mmcinfo
>> Device: FSL_SDHC
>> Manufacturer ID: 0
>> OEM: 0
>> Name: Tran Speed: 0
>> Rd Block Len: 0
>> MMC version 0.0
>> High Capacity: No
>> Capacity: 0 Bytes
>> Bus Width: 0-bit
>> =>
>>
>> Signed-off-by: Haijun Zhang <Haijun.Zhang@freescale.com>
>> Signed-off-by: Xie Shaohui-B21989 <B21989@freescale.com>
> Tested-by: Ryan Barnett <rjbarnet@rockwellcollins.com>
>
> Verified that this patch fixes issues related to booting from eSDHC
> interface on the P2041RDB with U-Boot 2013.10.
>
>> ---
>>   drivers/mmc/fsl_esdhc.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
>> index a7170b4..d4c1eef 100644
>> --- a/drivers/mmc/fsl_esdhc.c
>> +++ b/drivers/mmc/fsl_esdhc.c
>> @@ -521,6 +521,7 @@ int fsl_esdhc_initialize(bd_t *bis, struct
> fsl_esdhc_cfg *cfg)
>>      if (!mmc)
>>         return -ENOMEM;
>>
>> +   memset(mmc, 0, sizeof(struct mmc));
>>      sprintf(mmc->name, "FSL_SDHC");
>>      regs = (struct fsl_esdhc *)cfg->esdhc_base;
>>
>> -- 
>> 1.8.4
>>
>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>

-- 
Thanks & Regards
Haijun.

  reply	other threads:[~2013-10-28  2:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-25  1:54 [U-Boot] [PATCH 1/2] esdhc: memset mmc struct before putting into use Haijun Zhang
2013-10-25  1:54 ` [U-Boot] [PATCH 2/2] powerpc/esdhc: hack t4240 host capabilities register for VS33 bit Haijun Zhang
2013-10-25  3:24   ` sun york-R58495
2013-10-29 18:34   ` Scott Wood
2013-10-30  3:52     ` Zhang Haijun
2013-10-25 16:28 ` [U-Boot] [PATCH 1/2] esdhc: memset mmc struct before putting into use Ryan Barnett
2013-10-28  2:00   ` Zhang Haijun [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-10-25  4:36 Haijun Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=526DC53A.1050205@freescale.com \
    --to=b42677@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox