public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RESEND PATCH 2/3] mx28evk: Add 'nandboot' environment command
Date: Mon, 28 Oct 2013 12:32:30 +0100	[thread overview]
Message-ID: <526E4B4E.6000204@denx.de> (raw)
In-Reply-To: <CAP9ODKonHj=06_cjH42CEaWuDOSFiwd=gGDZu2_vod_hPn7fLQ@mail.gmail.com>

Hi Otavio,

On 28/10/2013 12:19, Otavio Salvador wrote:
> Hello,
> 
> I am not sure I agree ...
> 
> On Sun, Oct 27, 2013 at 6:47 PM, Marek Vasut <marex@denx.de> wrote:
>> Dear Otavio Salvador,
>>
>>> On Sun, Oct 27, 2013 at 2:16 PM, Marek Vasut <marex@denx.de> wrote:
>>>> Dear Otavio Salvador,
>>>>
>>>>> This reads the kernel, ftd and boot into ubifs filesystem. While on
>>>>> that, the SD firmware filename definition has been moved next to the
>>>>> other SD related commands.
>>>>>
>>>>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>>>>
>>>> Any changes to built-in environment are now NAKd I believe.
>>>
>>> I don't see a reason to not merged it for now; I will work in porting
>>> the environments for the external file but this could go now, anyway.
>>
>> Read [1], in particular what Stefano said.
>>
>> http://comments.gmane.org/gmane.comp.boot-loaders.u-boot/169042
>>
>> Thus this patch shall be rejected as well, sorry.
> 
> I agree with the goal but until we have a way to insert the /default/
> environment into the binary of U-Boot for use (not adding an extra
> environment image) this should be accepted.

Indeed. However, why cannot we do the right thing soon ?

It is very interesting if Simon's patches will flow into mainline soon -
as feeling, I see some comments by Wolfgang, but no evident signal that
they will be stopped. Octavio, I will wait for your patches for a while
and if Simon's patches will be accepted soon, I will kindly ask you to
reformat your patches, moving the default environment into an .env file.

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  parent reply	other threads:[~2013-10-28 11:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-21 23:24 [U-Boot] [RESEND PATCH 0/3] mx28evk environment rework for NAND support Otavio Salvador
2013-10-21 23:24 ` [U-Boot] [RESEND PATCH 1/3] mx28evk: Use 512k for fdt partition to align it Otavio Salvador
2013-10-21 23:24 ` [U-Boot] [RESEND PATCH 2/3] mx28evk: Add 'nandboot' environment command Otavio Salvador
2013-10-27 16:16   ` Marek Vasut
2013-10-27 19:51     ` Otavio Salvador
2013-10-27 20:47       ` Marek Vasut
2013-10-28 11:19         ` Otavio Salvador
2013-10-28 11:31           ` Marek Vasut
2013-10-28 11:32           ` Stefano Babic [this message]
2013-10-28 12:03             ` Otavio Salvador
2013-10-28 13:21               ` Wolfgang Denk
2013-10-28 13:29                 ` Otavio Salvador
2013-10-28 13:41                   ` Wolfgang Denk
2013-10-28 13:53                   ` Stefano Babic
2013-10-21 23:24 ` [U-Boot] [RESEND PATCH 3/3] mx28evk: Extend environment to easy write of NAND system Otavio Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=526E4B4E.6000204@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox