From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 28 Oct 2013 17:55:52 -0400 Subject: [U-Boot] Illegal use of FP ops in clock_ti814x.c In-Reply-To: <20131027211157.1AF2E380495@gemini.denx.de> References: <20131027211157.1AF2E380495@gemini.denx.de> Message-ID: <526EDD68.3050907@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 10/27/2013 05:11 PM, Wolfgang Denk wrote: > Dear Matt, > > I hope you are the right person to address this to - if not, > please help to redirect to the current responsible developer. > > Function pll_sigma_delta_val() in > arch/arm/cpu/armv7/am33xx/clock_ti814x.c incorrectly uses "float" > data, which results in FP operations which are not permitted in > U-Boot. > > The actual computation appears simple enough so a rewrite of the > code without using any floating point operations should be fairly > easy, but I don't understand the actual logic of this code, so I'd > rather leave this to someone who does. > > Could you please help and clean up these three lines of code? Matt's moved on to Linaro now (and this is a more public poke to update the maintainers entry you owe me). Care to look at this? - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSbt1nAAoJENk4IS6UOR1Wdy8P/RT18/UG5TBQugaSdqAkscS1 oMRz5M35qZvUuTjRj7JwRMXs/WGhVLO4NP5zDM0eYdo6pD/Z4ZnCPXUpRa46w4X/ xvusu9m+fpKsy/+gEOeOw4+JQ1OnMCLuP0OxpJfvKYwXEOjji5mGxAhxpCTogBFX 6l6vAYiEcYYG2S58AuGFYL9l0y0x7kZNnvfAzM5xJgxNOhxmGefGABuILXWRs5mt rHQBrPlofc+E2n73BxSAxk35cqy1Fm6CP35ETuKb3NMonoYbtXebh3ADyjxaNdf6 IZHpTserTNLaSGUSq2QVrF9zOnQKj/R4fuTbV7biUI3lF5JqVLO+jsx+E5XwTJpD bkQlD+vbmSnzK5HebUG6qEFHWxChjPJ0URSvlb0WBrlQJX9TkK4Xetq9ou6FaSpR xnZ/X6zDuBiuyWdmw01D0en8WSTMHCnYHQ7yAZjL3tuvjoJ6p4xCMFe2FZJE4UUn p1pT+h3zMipwjDrZ57NureCY7mWdCsRBgIR18MTmjF7XYzo7+4F+yi2aaGifGmPu zo1zp+1ijjQCVylw2OXGp09ej6azJcVoaRVS7FBEtd5u6MaSBhgfXTvR1bSB5mqw PbxlnXgfumv+VK3S036FtFXuT8lCx6kWlSLOa9HZSHrwjO0eQv+IeuoVigUnzfq/ oMHEAwDoaJbMjPDgFE2O =c8xm -----END PGP SIGNATURE-----