From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] ARM: tegra: Add the Tamonten™ NG Evaluation Carrier board
Date: Mon, 28 Oct 2013 16:00:06 -0600 [thread overview]
Message-ID: <526EDE66.2060402@wwwdotorg.org> (raw)
In-Reply-To: <1382365726-29140-1-git-send-email-alban.bedel@avionic-design.de>
On 10/21/2013 08:28 AM, Alban Bedel wrote:
> Add support for the new Tamonten? NG platform from Avionic Design.
> Currently only I2C, MMC, USB and ethernet have been tested.
What changed in v3? There's no changelog here, so I don't know where to
concentrate my re-review of this patch...
> diff --git a/board/avionic-design/common/tamonten-ng.c b/board/avionic-design/common/tamonten-ng.c
> +#define MAX_I2C_RETRY 3
I don't think that's used any more.
Most of the PMU #defines aren't used either.
> +#ifdef CONFIG_BOARD_EARLY_INIT_F
I don't think any of these ifdefs are required, since the config file
hard-codes all those values. Same for #if defined(CONFIG_TEGRA_MMC)
below, and perhaps more?
> +void gpio_early_init(void)
> +{
> + /* Turn on the alive signal */
> + gpio_request(GPIO_PV2, "ALIVE");
> + gpio_direction_output(GPIO_PV2, 1);
> +
> + /* Remove the reset on the reset on the external periph */
"reset on the reset on the" ?
> diff --git a/board/avionic-design/dts/tegra30-tamonten.dtsi b/board/avionic-design/dts/tegra30-tamonten.dtsi
> + i2c at 7000c000 {
> + status = "okay";
> + clock-frequency = <100000>;
> + };
> +
> + i2c at 7000c400 {
> + status = "okay";
> + clock-frequency = <100000>;
> + };
...
Do all the carrier boards guarantee that all those I2C and SPI, and even
SDHCI busses are routed somewhere? It may be best to defer adding
status="okay" to the leaf board files, so you know there's actually
something hooked up there.
next prev parent reply other threads:[~2013-10-28 22:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-17 14:29 [U-Boot] [PATCH v2 0/2] ARM: tegra: Add the Tamonten-NG Evaluation carrier boards Alban Bedel
2013-10-17 14:29 ` [U-Boot] [PATCH v2 1/2] ARM: tegra: support SKU b1 of Tegra30 Alban Bedel
2013-10-17 19:20 ` Stephen Warren
2013-10-17 14:29 ` [U-Boot] [PATCH v2 2/2] ARM: tegra: Add the Tamonten™ NG Evaluation Carrier board Alban Bedel
2013-10-17 19:23 ` Stephen Warren
2013-10-21 14:28 ` [U-Boot] [PATCH v3] " Alban Bedel
2013-10-28 13:02 ` Tom Warren
2013-10-28 22:00 ` Stephen Warren [this message]
2013-10-30 11:19 ` Alban Bedel
2013-10-30 15:35 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526EDE66.2060402@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox