From mboxrd@z Thu Jan 1 00:00:00 1970 From: Przemyslaw Marczak Date: Tue, 29 Oct 2013 14:24:26 +0100 Subject: [U-Boot] [PATCH v2] mmc: sdhci: Avoid commands errors by simple timeout adaptation. In-Reply-To: <72574FF8-F557-46FF-999D-9DF092F740A7@antoniou-consulting.com> References: <1380629761-16502-1-git-send-email-p.marczak@samsung.com> <1381248729-21470-1-git-send-email-p.marczak@samsung.com> <525DA307.7060305@samsung.com> <526FB1CD.6030003@samsung.com> <72574FF8-F557-46FF-999D-9DF092F740A7@antoniou-consulting.com> Message-ID: <526FB70A.7010603@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Pantelis, On 10/29/2013 02:08 PM, Pantelis Antoniou wrote: > Dear Przemyslaw, > > On Oct 29, 2013, at 3:02 PM, Przemyslaw Marczak wrote: > >> Dear Pantelis, >> You don't reply for a long time. Could you look on it at this time? >> > > Is this a way to address people on a mailing list? > > People, especially volunteers are busy with other things too. > > Eventually things get merged, but not when people are being rude. What did I wrong by contacting mmc-u-boot custodian via the mailing list? At least for linux it is a good and common practice to "ping" maintainers after 2 weeks of not reply to the patch. > >> On 10/15/2013 10:18 PM, Przemyslaw Marczak wrote: >>> Hello Pantelis, >>> >>> Could you look at this patch, please? >>> >>> On 10/08/2013 06:12 PM, Przemyslaw Marczak wrote: >>>> Old command timeout value was too small and it caused I/O errors which >>>> led to uncompleted read/write/erase operations and filesystem errors. >>>> Timeout adaptation fixes this issue. >>>> >>>> Changes in sdhci_send_command() function: >>>> - change timeout variable to static >>>> - increase default command timeout to 100 ms >>>> - add definition of max command timeout value, >>>> which can be redefined in each board config file >>>> - wait for card ready state for max defined time >>>> if it doesn't exceed defined maximum or return COMM_ERR >>>> >>>> Once successfully increased timeout value will be used in next function >>>> call. This fix was tested on Goni, Trats, Trats2 boards by testing UMS >>>> on MMC storage. >>>> >>>> Changes v2: >>>> - move global variable cmd_timeout into function sdhci_send_command() >>>> - change condition "==" to ">=" when comparing time with timeout >>>> - print information about timeout increasing and card busy timeout >>>> >>>> Signed-off-by: Przemyslaw Marczak >>>> Cc: Pantelis Antoniou >>> >>> Thank you. >>> >>> >> >> Regards >> -- >> Przemyslaw Marczak >> Samsung R&D Institute Poland >> Samsung Electronics >> p.marczak at samsung.com > > Regards > > -- Pantelis > Regards -- Przemyslaw Marczak Samsung R&D Institute Poland Samsung Electronics p.marczak at samsung.com