public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] video: ipu_disp: Fix clock polarity logic
Date: Tue, 29 Oct 2013 16:03:30 -0700	[thread overview]
Message-ID: <52703EC2.1040509@boundarydevices.com> (raw)
In-Reply-To: <1383068781-9299-1-git-send-email-fabio.estevam@freescale.com>

Thanks Fabio,

On 10/29/2013 10:46 AM, Fabio Estevam wrote:
> Currently the HDMI splash screen image quality on mx6solo does not show a
> very stable image.
>
> By comparing the IPU driver from U-boot with the one from FSL 4.1.0 BSP,
> we can see that there is an inverted logic for setting the DI_GEN_POL_CLK bit.
>
>  From FSL BSP [1] we have:
>
> 	if (!sig.clk_pol)
> 		di_gen |= DI_GEN_POLARITY_DISP_CLK;
>
> Applying the same logic into U-boot fixes the HDMI image stability.
>

It's odd that this doesn't appear to change things for the i.MX6DQ,
but it works on either one, so

Tested-by: Eric Nelson <eric.nelson@boundarydevices.com>
Acked-by: Eric Nelson <eric.nelson@boundarydevices.com>

  reply	other threads:[~2013-10-29 23:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-29 17:46 [U-Boot] [PATCH] video: ipu_disp: Fix clock polarity logic Fabio Estevam
2013-10-29 23:03 ` Eric Nelson [this message]
2013-10-30  8:59 ` Stefano Babic
2013-10-30  9:07 ` Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52703EC2.1040509@boundarydevices.com \
    --to=eric.nelson@boundarydevices.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox