From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] video: ipu_disp: Fix clock polarity logic
Date: Wed, 30 Oct 2013 09:59:16 +0100 [thread overview]
Message-ID: <5270CA64.6060406@denx.de> (raw)
In-Reply-To: <1383068781-9299-1-git-send-email-fabio.estevam@freescale.com>
On 29/10/2013 18:46, Fabio Estevam wrote:
> Currently the HDMI splash screen image quality on mx6solo does not show a
> very stable image.
>
> By comparing the IPU driver from U-boot with the one from FSL 4.1.0 BSP,
> we can see that there is an inverted logic for setting the DI_GEN_POL_CLK bit.
>
> From FSL BSP [1] we have:
>
> if (!sig.clk_pol)
> di_gen |= DI_GEN_POLARITY_DISP_CLK;
>
> Applying the same logic into U-boot fixes the HDMI image stability.
>
> [1] git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/tree/drivers/mxc/ipu3/ipu_disp.c?h=imx_3.0.35_4.1.0
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> drivers/video/ipu_disp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/ipu_disp.c b/drivers/video/ipu_disp.c
> index 2e91356..22ac142 100644
> --- a/drivers/video/ipu_disp.c
> +++ b/drivers/video/ipu_disp.c
> @@ -1178,7 +1178,7 @@ int32_t ipu_init_sync_panel(int disp, uint32_t pixel_clk,
> if (sig.Vsync_pol)
> di_gen |= DI_GEN_POLARITY_3;
>
> - if (sig.clk_pol)
> + if (!sig.clk_pol)
> di_gen |= DI_GEN_POL_CLK;
>
> }
>
Acked-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2013-10-30 8:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 17:46 [U-Boot] [PATCH] video: ipu_disp: Fix clock polarity logic Fabio Estevam
2013-10-29 23:03 ` Eric Nelson
2013-10-30 8:59 ` Stefano Babic [this message]
2013-10-30 9:07 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5270CA64.6060406@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox