From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Wed, 30 Oct 2013 11:12:38 +0100 Subject: [U-Boot] [RFC PATCH 1/7] arm: atmel: sama5d3: early enable PIO peripherals In-Reply-To: <1383124508-8413-2-git-send-email-voice.shen@atmel.com> References: <1383124508-8413-1-git-send-email-voice.shen@atmel.com> <1383124508-8413-2-git-send-email-voice.shen@atmel.com> Message-ID: <5270DB96.70100@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello bo, Am 30.10.2013 10:15, schrieb Bo Shen: > Enable the PIO peripherals early that other peripherals. > > Signed-off-by: Bo Shen > --- > board/atmel/sama5d3xek/sama5d3xek.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/board/atmel/sama5d3xek/sama5d3xek.c b/board/atmel/sama5d3xek/sama5d3xek.c > index b0965ef..7fa3ae7 100644 > --- a/board/atmel/sama5d3xek/sama5d3xek.c > +++ b/board/atmel/sama5d3xek/sama5d3xek.c > @@ -158,6 +158,9 @@ void lcd_show_board_info(void) > > int board_early_init_f(void) > { > + at91_periph_clk_enable(ATMEL_ID_PIOA | ATMEL_ID_PIOB | ATMEL_ID_PIOC | > + ATMEL_ID_PIOD | ATMEL_ID_PIOE); > + > at91_seriald_hw_init(); > > return 0; Hmm.. you do this board specific. I think, we should make there a more generic approach. Could we create here a arch/arm/cpu/arm926ejs/at91/spl.c and collect such common code? This comment aplly also for your patch: http://patchwork.ozlabs.org/patch/287165/ bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany