public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc/t1040qds: Add DDR Raw Timing support
Date: Wed, 30 Oct 2013 09:43:40 -0700	[thread overview]
Message-ID: <5271373C.4040002@freescale.com> (raw)
In-Reply-To: <1382694544-16133-1-git-send-email-Priyanka.Jain@freescale.com>

On 10/25/2013 02:49 AM, Priyanka Jain wrote:
> T1040QDS-D3 has dual-rank DDR:
> 	Micron, MT18KSF51272AZ-1G6 (4GB, x72, CL=10).
> Add Raw Timing structure for this DDR.
> 
> Typically SPD method is used for getting DDR parameter
> and calculating values for various DDR controller registers.
> 
> But somentimes it may happen that SPD present on DDR may get
> accidently erased or is not working properly during initial
> bring-up. In that circumnstance, DDR raw timing structure can be
> use as fallback option for getting DDR parameters.
> 
> Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
> Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com>
> ---

I don't think it is appropriate to use raw timing for this application.
This board use DIMMs, not soldered DDR chips. In normal cases, this
piece of code is not used. It is only useful if you have a DIMM without
a valid SPD. You could get another DIMM. I am not saying this patch is
wrong, it is just useless for general public.

York

  reply	other threads:[~2013-10-30 16:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-25  9:49 [U-Boot] [PATCH] powerpc/t1040qds: Add DDR Raw Timing support Priyanka Jain
2013-10-30 16:43 ` York Sun [this message]
2013-10-31  4:55   ` Jain Priyanka-B32167
2013-10-31  5:19     ` sun york-R58495
2013-11-11  5:20       ` Priyanka Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5271373C.4040002@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox