From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jens Scharsig <js_at_ng@scharsoft.de>
Date: Wed, 30 Oct 2013 18:19:57 +0100
Subject: [U-Boot] [RFC PATCH 1/3] at91: add new gpio pin macros
In-Reply-To: <5270E1EE.1050503@gmail.com>
References: <1383051191-29363-1-git-send-email-andreas.devel@googlemail.com>
	<1383051191-29363-2-git-send-email-andreas.devel@googlemail.com>
	<5270D7D4.1060205@atmel.com> <5270E1EE.1050503@gmail.com>
Message-ID: <52713FBD.202@scharsoft.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Am 30.10.2013 11:39, schrieb Andreas Bie?mann:
> Hi Bo,
> 
> +Jens, he did the rewrite of the at91 gpio driver.
> 

> 
> I think this is a job for gpio_is_valid() then. How is this case handled
> in kernel?
> 
> Here are a few things to discuss. First of all I'd like to get some
> insights why the at91 gpio API was changed back in 2010. It was a plain
> number before and was changed to PORT + PIN as two separate parameters.
> Jens, could you please shed some light on this?
> 

Sorry, but I don't remember me why we do this. I think, it was a
compromise between number of changes and code size.

Regards

Jens