From: Bo Shen <voice.shen@atmel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 2/7] arm: atmel: sama5d3: correct the ID for DBGU and PIT
Date: Thu, 31 Oct 2013 09:32:19 +0800 [thread overview]
Message-ID: <5271B323.3020006@atmel.com> (raw)
In-Reply-To: <5270E9AD.6050200@gmail.com>
Hi Andreas,
On 10/30/2013 19:12, Andreas Bie?mann wrote:
> Hi Bo,
>
> On 10/30/2013 10:15 AM, Bo Shen wrote:
>> As the DBGU and PIT has its own ID on sama5d3 SoC, while not share
>> with SYS ID. So, correct them.
>>
>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>> ---
>> arch/arm/cpu/armv7/at91/sama5d3_devices.c | 2 +-
>> arch/arm/cpu/armv7/at91/timer.c | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/cpu/armv7/at91/sama5d3_devices.c b/arch/arm/cpu/armv7/at91/sama5d3_devices.c
>> index 51f0a6d..ebe99d2 100644
>> --- a/arch/arm/cpu/armv7/at91/sama5d3_devices.c
>> +++ b/arch/arm/cpu/armv7/at91/sama5d3_devices.c
>> @@ -82,7 +82,7 @@ void at91_seriald_hw_init(void)
>> at91_set_a_periph(AT91_PIO_PORTB, 30, 0); /* DRXD */
>>
>> /* Enable clock */
>> - at91_periph_clk_enable(ATMEL_ID_SYS);
>> + at91_periph_clk_enable(ATMEL_ID_DBGU);
>> }
>>
>> #if defined(CONFIG_ATMEL_SPI)
>> diff --git a/arch/arm/cpu/armv7/at91/timer.c b/arch/arm/cpu/armv7/at91/timer.c
>> index 3808aed..e3ebfe0 100644
>> --- a/arch/arm/cpu/armv7/at91/timer.c
>> +++ b/arch/arm/cpu/armv7/at91/timer.c
>> @@ -60,7 +60,7 @@ int timer_init(void)
>> at91_pit_t *pit = (at91_pit_t *)ATMEL_BASE_PIT;
>>
>> /* Enable PITC Clock */
>> - at91_periph_clk_enable(ATMEL_ID_SYS);
>> + at91_periph_clk_enable(ATMEL_ID_PIT);
>>
>> /* Enable PITC */
>> writel(TIMER_LOAD_VAL | AT91_PIT_MR_EN , &pit->mr);
>>
>
> I think these two are generic bug fixes, could you please send them as
> not RFC for inclusion?
OK, I will remove RFC for inclusion in v2.
> Best regards
>
> Andreas Bie?mann
>
Best Regards,
Bo Shen
next prev parent reply other threads:[~2013-10-31 1:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 9:15 [U-Boot] [RFC PATCH 0/7] arm: atmel: sama5d3: enable spl boot from SD card Bo Shen
2013-10-30 9:15 ` [U-Boot] [RFC PATCH 1/7] arm: atmel: sama5d3: early enable PIO peripherals Bo Shen
2013-10-30 10:12 ` Heiko Schocher
2013-10-30 11:11 ` Andreas Bießmann
2013-10-31 2:02 ` Bo Shen
2013-10-30 9:15 ` [U-Boot] [RFC PATCH 2/7] arm: atmel: sama5d3: correct the ID for DBGU and PIT Bo Shen
2013-10-30 11:12 ` Andreas Bießmann
2013-10-31 1:32 ` Bo Shen [this message]
2013-10-30 9:15 ` [U-Boot] [RFC PATCH 3/7] arm: atmel: the offset of MULA is 18 in sama5d3 Bo Shen
2013-10-30 9:15 ` [U-Boot] [RFC PATCH 4/7] arm: atmel: sama5: correct the error define of DIV Bo Shen
2013-10-30 9:15 ` [U-Boot] [RFC PATCH 5/7] arm: atmel: add plla and mck initialize function Bo Shen
2013-10-30 11:21 ` Andreas Bießmann
2013-10-31 1:38 ` Bo Shen
2013-10-30 9:15 ` [U-Boot] [RFC PATCH 6/7] arm: atmel: add ddr2 initialization function Bo Shen
2013-10-30 9:15 ` [U-Boot] [RFC PATCH 7/7] spl: mmc: FAT support boot u-boot Bo Shen
2013-10-30 10:15 ` Heiko Schocher
2013-10-30 10:43 ` Andreas Bießmann
2013-10-30 10:57 ` Heiko Schocher
2013-10-30 11:02 ` Andreas Bießmann
2013-10-31 1:30 ` Bo Shen
2013-10-31 7:42 ` Heiko Schocher
2013-10-31 7:50 ` Bo Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5271B323.3020006@atmel.com \
--to=voice.shen@atmel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox