From: myan <miao.yan@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 0/5] Add device tree support for VxWorks
Date: Fri, 1 Nov 2013 15:44:10 +0800 [thread overview]
Message-ID: <52735BCA.3010605@windriver.com> (raw)
In-Reply-To: <52723F9C.7080509@ti.com>
Hi Tom,
On 10/31/2013 07:31 PM, Tom Rini wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 10/31/2013 05:56 AM, myan wrote:
>>>
>>
>> Will this go into master in this merge window ?
>>
>> And I noticed there are some changes to common do_bootm, which
>> reqiures adjustment to vxworks subcommand handling code, do I need
>> to rebase and resend the patches ? Thanks.
>
> Yes, it can come in, I just have been a bit busy and getting behind on
> collecting up patches. If you can re-base and re-test things I'd
> appreciate it, thanks!
>
I re-tested against master but found a problem. In commit
"5c427e4: use BOOTM_STATE_OS_CMDLINE flag for plain bootm" and "3d187b3:
Only pass BOOTM_STATE_OS_CMDLINE on PowerPC/MIPS",
BOOTM_STATE_OS_CMLINE was added to do_bootm for PowerPC and MIPS. This
breaks other OSes (vxworks, netbsd, plan9,...) that don't support
subcommand processing, e.g. they all contain the following code in their
do_bootm_xxx():
if (flag & BOOTM_STATE_OS_PREP)
return 0;
if ((flag != 0) && (flag != BOOTM_STATE_OS_GO))
return 1;
which will result a "subcommand not supported" error. IMO, the above
code should be converted to something like this:
/* if not go command, pretend everything to be OK */
if (flag != BOOTM_STATE_OS_GO)
return 0;
And if you are OK with it, I could send patches to clean them up. Thanks.
Miao
next prev parent reply other threads:[~2013-11-01 7:44 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 9:58 [U-Boot] [PATCH 0/5] Add device tree support for VxWorks Miao Yan
2013-09-16 9:58 ` [U-Boot] [PATCH 1/5] common/cmd_bootm.c: seperate do_bootm_vxworks related code from CONFIG_CMD_ELF Miao Yan
2013-09-16 9:58 ` [U-Boot] [PATCH 2/5] common/config_defaults.h: make CONFIG_BOOTM_VXWORKS default configuration Miao Yan
2013-09-16 9:58 ` [U-Boot] [PATCH 3/5] common/cmd_bootm: extend do_bootm_vxworks to support the new VxWorks boot interface Miao Yan
2013-09-16 9:58 ` [U-Boot] [PATCH 4/5] common/fdt_support.c: avoid unintended return from fdt_fixup_memory_banks() Miao Yan
2013-09-16 9:58 ` [U-Boot] [PATCH 5/5] doc/README.vxworks: add a document describing the new VxWorks boot interface Miao Yan
2013-09-16 19:35 ` [U-Boot] [PATCH 0/5] Add device tree support for VxWorks Wolfgang Denk
2013-09-17 2:14 ` myan
2013-09-17 6:14 ` Wolfgang Denk
2013-09-17 7:44 ` myan
2013-09-17 11:33 ` [U-Boot] [PATCH v2 " Miao Yan
2013-09-17 11:33 ` [U-Boot] [PATCH v2 1/5] common/cmd_bootm.c: seperate do_bootm_vxworks related code from CONFIG_CMD_ELF Miao Yan
2013-11-28 9:51 ` [U-Boot] [PATCH v3 " myan
2013-11-28 9:51 ` [U-Boot] [PATCH v3 2/5] common/config_defaults.h: make CONFIG_BOOTM_VXWORKS default configuration myan
2013-12-16 14:14 ` [U-Boot] [U-Boot, v3, " Tom Rini
2013-11-28 9:51 ` [U-Boot] [PATCH v3 3/5] common/cmd_bootm: extend do_bootm_vxworks to support the new VxWorks boot interface myan
2013-12-16 14:14 ` [U-Boot] [U-Boot, v3, " Tom Rini
2013-11-28 9:51 ` [U-Boot] [PATCH v3 4/5] common/fdt_support.c: avoid unintended return from fdt_fixup_memory_banks() myan
2013-12-16 14:14 ` [U-Boot] [U-Boot, v3, " Tom Rini
2013-11-28 9:51 ` [U-Boot] [PATCH v3 5/5] README.vxworks: add a document describing the new VxWorks boot interface myan
2013-12-16 14:15 ` [U-Boot] [U-Boot, v3, " Tom Rini
2013-12-16 14:17 ` [U-Boot] [U-Boot, v3, 1/5] common/cmd_bootm.c: seperate do_bootm_vxworks related code from CONFIG_CMD_ELF Tom Rini
2013-09-17 11:34 ` [U-Boot] [PATCH v2 2/5] common/config_defaults.h: make CONFIG_BOOTM_VXWORKS default configuration Miao Yan
2013-09-17 11:34 ` [U-Boot] [PATCH v2 3/5] common/cmd_bootm: extend do_bootm_vxworks to support the new VxWorks boot interface Miao Yan
2013-09-17 11:34 ` [U-Boot] [PATCH v2 4/5] common/fdt_support.c: avoid unintended return from fdt_fixup_memory_banks() Miao Yan
2013-09-17 11:34 ` [U-Boot] [PATCH v2 5/5] doc/README.vxworks: add a document describing the new VxWorks boot interface Miao Yan
2013-09-18 6:14 ` [U-Boot] [PATCH v2 0/5] Add device tree support for VxWorks myan
2013-09-22 2:57 ` myan
2013-09-23 23:27 ` Tom Rini
2013-10-31 9:56 ` myan
2013-10-31 11:31 ` Tom Rini
2013-11-01 7:44 ` myan [this message]
2013-11-01 12:23 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52735BCA.3010605@windriver.com \
--to=miao.yan@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox