From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vidya Sagar Date: Fri, 1 Nov 2013 18:58:45 +0530 Subject: [U-Boot] [PATCH] tegra: allow build to succeed with SPL disabled In-Reply-To: <113ACA888B71994BB56E5CF3704953486D6631A701@BGMAIL02.nvidia.com> References: <1383211298-31071-1-git-send-email-vidyas@nvidia.com>, <5FBF8E85CA34454794F0F7ECBA79798F37F2850D6E@HQMAIL04.nvidia.com> <113ACA888B71994BB56E5CF3704953486D6631A701@BGMAIL02.nvidia.com> Message-ID: <5273AC8D.6010508@nvidia.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/31/2013 11:58 PM, wrote: > ________________________________________ > From: Tom Warren > Sent: Thursday, October 31, 2013 9:38 PM > To: Vidya Sagar;u-boot at lists.denx.de > Cc: Stephen Warren; Vidya Sagar; Tom Warren > Subject: RE: [PATCH] tegra: allow build to succeed with SPL disabled > > Vidya, > >> -----Original Message----- >> From: Vidya Sagar [mailto:vidyas at nvidia.com] >> Sent: Thursday, October 31, 2013 2:22 AM >> To:u-boot at lists.denx.de >> Cc: Tom Warren; Stephen Warren; Vidya Sagar >> Subject: [PATCH] tegra: allow build to succeed with SPL disabled >> >> u-boot-dtb-tegra.bin and u-boot-nodtb-tegra.bin binaries are generated >> only if the SPL build is enabled as they have dependency on SPL build >> >> Signed-off-by: Vidya Sagar >> --- >> Makefile | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Makefile b/Makefile >> index 1365db6..3c71082 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -407,12 +407,14 @@ endif >> >> # enable combined SPL/u-boot/dtb rules for tegra ifneq >> ($(CONFIG_TEGRA),) >> +ifeq ($(CONFIG_SPL),y) >> ifeq ($(CONFIG_OF_SEPARATE),y) >> ALL-y += $(obj)u-boot-dtb-tegra.bin >> else >> ALL-y += $(obj)u-boot-nodtb-tegra.bin >> endif >> endif >> +endif >> >> all: $(ALL-y) $(SUBDIR_EXAMPLES) >> >> -- >> 1.8.1.5 > LGTM, thanks. I assume you built all Tegra boards using MAKEALL? > > If so, then: > Acked-by: Tom Warren > -- > nvpublic yes, I've built for all nvidia boards. Here is the log... #./MAKEALL -v nvidia Configuring for dalmore board... text data bss dec hex filename 256692 15308 309924 581924 8e124 /home/vidyas/x/uboot/for_upstreaming/u-boot-tegra/../out/u-boot Configuring for harmony board... text data bss dec hex filename 295786 11870 311232 618888 97188 /home/vidyas/x/uboot/for_upstreaming/u-boot-tegra/../out/u-boot Configuring for seaboard board... text data bss dec hex filename 310284 13450 309544 633278 9a9be /home/vidyas/x/uboot/for_upstreaming/u-boot-tegra/../out/u-boot Configuring for ventana board... text data bss dec hex filename 248990 7690 307820 564500 89d14 /home/vidyas/x/uboot/for_upstreaming/u-boot-tegra/../out/u-boot Configuring for whistler board... text data bss dec hex filename 244038 9018 307768 560824 88eb8 /home/vidyas/x/uboot/for_upstreaming/u-boot-tegra/../out/u-boot Configuring for beaver board... text data bss dec hex filename 255926 16672 308676 581274 8de9a /home/vidyas/x/uboot/for_upstreaming/u-boot-tegra/../out/u-boot Configuring for cardhu board... text data bss dec hex filename 255926 16672 308676 581274 8de9a /home/vidyas/x/uboot/for_upstreaming/u-boot-tegra/../out/u-boot --------------------- SUMMARY ---------------------------- Boards compiled: 7 ----------------------------------------------------------