From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Mon, 04 Nov 2013 08:19:41 +0100 Subject: [U-Boot] [PATCH] titanium: Return the error when cpu_eth_init() fails In-Reply-To: <1383523976-11845-1-git-send-email-festevam@gmail.com> References: <1383523976-11845-1-git-send-email-festevam@gmail.com> Message-ID: <52774A8D.4030801@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Fabio, On 04.11.2013 01:12, Fabio Estevam wrote: > From: Fabio Estevam > > When cpu_eth_init() fails we should not return success. > > Signed-off-by: Fabio Estevam > --- > board/freescale/titanium/titanium.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/freescale/titanium/titanium.c b/board/freescale/titanium/titanium.c > index 6025eb7..9a317bc 100644 > --- a/board/freescale/titanium/titanium.c > +++ b/board/freescale/titanium/titanium.c > @@ -272,7 +272,7 @@ int board_eth_init(bd_t *bis) > if (ret) > printf("FEC MXC: %s:failed\n", __func__); > > - return 0; > + return ret; > } > > int board_early_init_f(void) Thanks. Acked-by: Stefan Roese Thanks, Stefan