* [U-Boot] [PATCH] titanium: Return the error when cpu_eth_init() fails
@ 2013-11-04 0:12 Fabio Estevam
2013-11-04 7:19 ` Stefan Roese
2013-11-13 9:14 ` Stefano Babic
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2013-11-04 0:12 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@freescale.com>
When cpu_eth_init() fails we should not return success.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
board/freescale/titanium/titanium.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/freescale/titanium/titanium.c b/board/freescale/titanium/titanium.c
index 6025eb7..9a317bc 100644
--- a/board/freescale/titanium/titanium.c
+++ b/board/freescale/titanium/titanium.c
@@ -272,7 +272,7 @@ int board_eth_init(bd_t *bis)
if (ret)
printf("FEC MXC: %s:failed\n", __func__);
- return 0;
+ return ret;
}
int board_early_init_f(void)
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* [U-Boot] [PATCH] titanium: Return the error when cpu_eth_init() fails
2013-11-04 0:12 [U-Boot] [PATCH] titanium: Return the error when cpu_eth_init() fails Fabio Estevam
@ 2013-11-04 7:19 ` Stefan Roese
2013-11-13 9:14 ` Stefano Babic
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Roese @ 2013-11-04 7:19 UTC (permalink / raw)
To: u-boot
Hi Fabio,
On 04.11.2013 01:12, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> When cpu_eth_init() fails we should not return success.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> board/freescale/titanium/titanium.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/freescale/titanium/titanium.c b/board/freescale/titanium/titanium.c
> index 6025eb7..9a317bc 100644
> --- a/board/freescale/titanium/titanium.c
> +++ b/board/freescale/titanium/titanium.c
> @@ -272,7 +272,7 @@ int board_eth_init(bd_t *bis)
> if (ret)
> printf("FEC MXC: %s:failed\n", __func__);
>
> - return 0;
> + return ret;
> }
>
> int board_early_init_f(void)
Thanks.
Acked-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread* [U-Boot] [PATCH] titanium: Return the error when cpu_eth_init() fails
2013-11-04 0:12 [U-Boot] [PATCH] titanium: Return the error when cpu_eth_init() fails Fabio Estevam
2013-11-04 7:19 ` Stefan Roese
@ 2013-11-13 9:14 ` Stefano Babic
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Babic @ 2013-11-13 9:14 UTC (permalink / raw)
To: u-boot
On 04/11/2013 01:12, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> When cpu_eth_init() fails we should not return success.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-13 9:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-04 0:12 [U-Boot] [PATCH] titanium: Return the error when cpu_eth_init() fails Fabio Estevam
2013-11-04 7:19 ` Stefan Roese
2013-11-13 9:14 ` Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox