From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] i2c: mxs_i2c: Squash endless loop
Date: Mon, 04 Nov 2013 10:01:27 +0100 [thread overview]
Message-ID: <52776267.7020905@denx.de> (raw)
In-Reply-To: <1383413009-4912-1-git-send-email-marex@denx.de>
Hi Marek,
On 02/11/2013 18:23, Marek Vasut wrote:
> + if (!timeout) {
> + debug("MXS I2C: Failed receiving data!\n");
> + return -EINVAL;
> + }
> +
This is a real error and not a debug information. IMHO it should be
better to print the error unconditionally with puts/printf, reporting
that the timer elapsed.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2013-11-04 9:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-02 17:23 [U-Boot] [PATCH] i2c: mxs_i2c: Squash endless loop Marek Vasut
2013-11-04 9:01 ` Stefano Babic [this message]
2013-11-04 11:50 ` Marek Vasut
2013-11-04 12:03 ` Stefano Babic
2013-11-04 12:18 ` Heiko Schocher
2013-11-04 13:13 ` Marek Vasut
2013-11-04 13:21 ` Heiko Schocher
2013-11-04 13:29 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52776267.7020905@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox