public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 4/4] arm, at91: add siemens corvus board
Date: Mon, 04 Nov 2013 11:51:14 +0100	[thread overview]
Message-ID: <52777C22.3040308@gmail.com> (raw)
In-Reply-To: <52776E8B.6000007@denx.de>

Hello Heiko,

On 11/04/2013 10:53 AM, Heiko Schocher wrote:
> Am 04.11.2013 09:53, schrieb Andreas Bie?mann:
>> On 11/04/2013 07:40 AM, Heiko Schocher wrote:

<snip>

>>> +
>>> +    erstl = readl(&rstc->mr)&  AT91_RSTC_MR_ERSTL_MASK;
>>> +
>>> +    /* Need to reset PHY ->  500ms reset */
>>> +    writel(AT91_RSTC_KEY | AT91_RSTC_MR_ERSTL(13) |
>>> +        AT91_RSTC_MR_URSTEN,&rstc->mr);
>>> +
>>> +    writel(AT91_RSTC_KEY | AT91_RSTC_CR_EXTRST,&rstc->cr);
>>> +
>>> +    /* Wait for end of reset */
>>> +    at91_wait_for_reset(100);
>>
>> You say above, that this will be 500ms reset pulse ... but wait just
>> 100ms. Is that Ok?
>> Please also check the taurus board.
> 
> We should rework this as Wolfgang suggested, or?

Sounds good. I wonder if exactly that would be the task of
CONFIG_RESET_PHY_R.

<snip>

>>> +#ifdef CONFIG_RESET_PHY_R
>>
>> Why provide empty reset_phy? Just remove the CONFIG_RESET_PHY_R in board
>> config.
> 
> removed.
> 

Best regards

Andreas Bie?mann

      parent reply	other threads:[~2013-11-04 10:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-04  6:40 [U-Boot] [PATCH v2 0/4] arm, at91: support for the taurus, axm and corvus board Heiko Schocher
2013-11-04  6:40 ` [U-Boot] [PATCH v2 1/4] at91: add defines for reset type Heiko Schocher
2013-11-04  8:16   ` Andreas Bießmann
2013-11-04 19:41   ` [U-Boot] [U-Boot,v2,1/4] " Andreas Bießmann
2013-11-04  6:40 ` [U-Boot] [PATCH v2 2/4] arm, at91: add function for waiting if reset ends Heiko Schocher
2013-11-04  8:20   ` Andreas Bießmann
2013-11-04  9:03   ` Wolfgang Denk
2013-11-04  9:11     ` Heiko Schocher
2013-11-04 10:35     ` Andreas Bießmann
2013-11-04  6:40 ` [U-Boot] [PATCH v2 3/4] arm, at91: add Siemens board taurus and axm Heiko Schocher
2013-11-04  8:43   ` Andreas Bießmann
2013-11-04  9:09     ` Heiko Schocher
2013-11-04 11:04       ` Andreas Bießmann
2013-11-04  6:40 ` [U-Boot] [PATCH v2 4/4] arm, at91: add siemens corvus board Heiko Schocher
2013-11-04  8:53   ` Andreas Bießmann
2013-11-04  9:53     ` Heiko Schocher
2013-11-04 10:15       ` Andreas Bießmann
2013-11-04 10:32         ` Heiko Schocher
2013-11-04 10:51       ` Andreas Bießmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52777C22.3040308@gmail.com \
    --to=andreas.devel@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox