From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?B?QW5kcmVhcyBCaWXDn21hbm4=?= <andreas.devel@googlemail.com>
Date: Mon, 04 Nov 2013 11:51:14 +0100
Subject: [U-Boot] [PATCH v2 4/4] arm, at91: add siemens corvus board
In-Reply-To: <52776E8B.6000007@denx.de>
References: <1383547247-7017-1-git-send-email-hs@denx.de>
	<1383547247-7017-5-git-send-email-hs@denx.de>
	<52776098.4010902@gmail.com> <52776E8B.6000007@denx.de>
Message-ID: <52777C22.3040308@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Heiko,

On 11/04/2013 10:53 AM, Heiko Schocher wrote:
> Am 04.11.2013 09:53, schrieb Andreas Bie?mann:
>> On 11/04/2013 07:40 AM, Heiko Schocher wrote:

<snip>

>>> +
>>> +    erstl = readl(&rstc->mr)&  AT91_RSTC_MR_ERSTL_MASK;
>>> +
>>> +    /* Need to reset PHY ->  500ms reset */
>>> +    writel(AT91_RSTC_KEY | AT91_RSTC_MR_ERSTL(13) |
>>> +        AT91_RSTC_MR_URSTEN,&rstc->mr);
>>> +
>>> +    writel(AT91_RSTC_KEY | AT91_RSTC_CR_EXTRST,&rstc->cr);
>>> +
>>> +    /* Wait for end of reset */
>>> +    at91_wait_for_reset(100);
>>
>> You say above, that this will be 500ms reset pulse ... but wait just
>> 100ms. Is that Ok?
>> Please also check the taurus board.
> 
> We should rework this as Wolfgang suggested, or?

Sounds good. I wonder if exactly that would be the task of
CONFIG_RESET_PHY_R.

<snip>

>>> +#ifdef CONFIG_RESET_PHY_R
>>
>> Why provide empty reset_phy? Just remove the CONFIG_RESET_PHY_R in board
>> config.
> 
> removed.
> 

Best regards

Andreas Bie?mann