[U-Boot] [PATCH] i2c: mxs_i2c: Squash endless loop

Stefano Babic
2013-11-04T09:01:27Z

Hi Marek,

On 02/11/2013 18:23, Marek Vasut wrote:

> + if (!timeout) {
> + debug("MXS I2C: Failed receiving data!\n");
> + return -EINVAL;
> + }
> +

This is a real error and not a debug information. IMHO it should be
better to print the error unconditionally with puts/printf, reporting
that the timer elapsed.

Best regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================