[U-Boot] [PATCH 07/34] zynq: Add UART0, UART1 configs support

Dinh Nguyen
2013-11-06T04:17:13Z

On 11/5/13 11:46 AM, Jagannadha Sutradharudu Teki wrote:
> Zynq uart controller support two serial ports like
> CONFIG_ZYNQ_SERIAL_UART0 and CONFIG_ZYNQ_SERIAL_UART1
> enabled both so-that the respective board will define
> these macros based on their usage.
>
> Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
> ---
> include/configs/zynq.h | 20 ++++++++++++++++----
> 1 file changed, 16 insertions(+), 4 deletions(-)
>
> diff --git a/include/configs/zynq.h b/include/configs/zynq.h
> index f32008b..1bcb28d 100644
> --- a/include/configs/zynq.h
> +++ b/include/configs/zynq.h
> @@ -33,10 +33,22 @@
> {300, 600, 1200, 2400, 4800, 9600, 19200, 38400, 57600, 115200, 230400}
>
> /* Zynq Serial driver */
> -#define CONFIG_ZYNQ_SERIAL
> -#define CONFIG_ZYNQ_SERIAL_BASEADDR0 0xE0001000
> -#define CONFIG_ZYNQ_SERIAL_BAUDRATE0 CONFIG_BAUDRATE
> -#define CONFIG_ZYNQ_SERIAL_CLOCK0 50000000
> +#define CONFIG_ZYNQ_SERIAL_UART1
> +#ifdef CONFIG_ZYNQ_SERIAL_UART0
> +# define CONFIG_ZYNQ_SERIAL_BASEADDR0 0xE0000000
> +# define CONFIG_ZYNQ_SERIAL_BAUDRATE0 CONFIG_BAUDRATE
Why couldn't you just use CONFIG_BAUDRATE? Why do you need to add
another define?

Dinh
> +# define CONFIG_ZYNQ_SERIAL_CLOCK0 50000000
> +#endif
> +
> +#ifdef CONFIG_ZYNQ_SERIAL_UART1
> +# define CONFIG_ZYNQ_SERIAL_BASEADDR1 0xE0001000
> +# define CONFIG_ZYNQ_SERIAL_BAUDRATE1 CONFIG_BAUDRATE
> +# define CONFIG_ZYNQ_SERIAL_CLOCK1 50000000
> +#endif
> +
> +#if defined(CONFIG_ZYNQ_SERIAL_UART0) || defined(CONFIG_ZYNQ_SERIAL_UART1)
> +# define CONFIG_ZYNQ_SERIAL
> +#endif
>
> /* DCC driver */
> #if defined(CONFIG_ZYNQ_DCC)