From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 6 Nov 2013 16:37:19 -0500 Subject: [U-Boot] [PATCH 05/14] ARM: AM43XX: board: add support for reading onboard EEPROM In-Reply-To: References: <1383625260-22294-1-git-send-email-lokeshvutla@ti.com> <1383625260-22294-6-git-send-email-lokeshvutla@ti.com> <527A4357.4010809@ti.com> Message-ID: <527AB68F.9040909@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 11/06/2013 11:39 AM, Vaibhav Bedia wrote: > On Wed, Nov 6, 2013 at 8:25 AM, Lokesh Vutla wrote: >> On Wednesday 06 November 2013 06:08 PM, Vaibhav Bedia wrote: >>> On Mon, Nov 4, 2013 at 11:20 PM, Lokesh Vutla wrote: >>>> From: Sekhar Nori >>>> >>>> Add support for reading onboard EEPROM to enable >>>> board detection. >>>> >>>> Signed-off-by: Sekhar Nori >>>> Signed-off-by: Lokesh Vutla >>>> --- >>>> arch/arm/include/asm/arch-am33xx/omap.h | 2 ++ >>>> board/ti/am43xx/board.c | 46 +++++++++++++++++++++++++++++++ >>>> board/ti/am43xx/board.h | 32 +++++++++++++++++++++ >>>> include/configs/am43xx_evm.h | 7 +++++ >>>> 4 files changed, 87 insertions(+) >>>> >>>> diff --git a/arch/arm/include/asm/arch-am33xx/omap.h b/arch/arm/include/asm/arch-am33xx/omap.h >>>> index 2250721..10f05c9 100644 >>>> --- a/arch/arm/include/asm/arch-am33xx/omap.h >>>> +++ b/arch/arm/include/asm/arch-am33xx/omap.h >>>> @@ -27,5 +27,7 @@ >>>> #define NON_SECURE_SRAM_START 0x402F0400 >>>> #define NON_SECURE_SRAM_END 0x40340000 >>>> #define SRAM_SCRATCH_SPACE_ADDR 0x4033C000 >>>> +#define AM4372_BOARD_NAME_START SRAM_SCRATCH_SPACE_ADDR >>>> +#define AM4372_BOARD_NAME_END SRAM_SCRATCH_SPACE_ADDR + 0xC >>>> #endif >>>> #endif >>>> diff --git a/board/ti/am43xx/board.c b/board/ti/am43xx/board.c >>>> index dcd8cbb..4fc1a40 100644 >>>> --- a/board/ti/am43xx/board.c >>>> +++ b/board/ti/am43xx/board.c >>>> @@ -9,6 +9,8 @@ >>>> */ >>>> >>>> #include >>>> +#include >>>> +#include >>>> #include >>>> #include >>>> #include >>>> @@ -17,6 +19,50 @@ >>>> >>>> DECLARE_GLOBAL_DATA_PTR; >>>> >>>> +/* >>>> + * Read header information from EEPROM into global structure. >>>> + */ >>>> +static int read_eeprom(struct am43xx_board_id *header) >>>> +{ >>>> + /* Check if baseboard eeprom is available */ >>>> + if (i2c_probe(CONFIG_SYS_I2C_EEPROM_ADDR)) { >>>> + printf("Could not probe the EEPROM at 0x%x\n", >>>> + CONFIG_SYS_I2C_EEPROM_ADDR); >>>> + return -ENODEV; >>>> + } >>>> + >>>> + /* read the eeprom using i2c */ >>>> + if (i2c_read(CONFIG_SYS_I2C_EEPROM_ADDR, 0, 2, (uchar *)header, >>>> + sizeof(struct am43xx_board_id))) { >>>> + printf("Could not read the EEPROM\n"); >>>> + return -EIO; >>>> + } >>>> + >>>> + if (header->magic != 0xEE3355AA) { >>> >>> Why is the header the same as AM335x? Shouldn't it be something >>> like 0xEE3344AA or whatever? >> No, the header is still same. It is 0xEE3355AA. >> > > My question was why ;) > What's the point of adding the same magic value for a different SoC? > Unless there's a good reason for doing so i think this needs to be fixed > in the EEPROM programmer. A magic value is sufficiently magical, I don't think we'll get anyone to change it at this point. - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSeraOAAoJENk4IS6UOR1W/JgP/jShfGcdKDNKJ8EcwAgdy+iU uFlC02b3f/I4cx7B4s0W3GWJVfHAlPlddSevzSE+I81/f+XRVy9w9Aso3J5hvD3e XJ/deA5xSpKMV4kZjhE0mOO62iemH4r5ewiM1WFbzUUoWIa1Jf+C8pjygvac5UJb DCIE40VigasMjl/bJbMOyZPKbrRbHIh+N7fFZNbo+WUp76ZM2dv0S1JWRaY/Zhpq 08wplMmlONGrOkRQmbVYTp2SPrSiYkxq98cIjyzqrzW2pAPDpWP9z7T5hlfI5iWz It9AENzEkJhmzHTt2P6wq4R9z+giAGweRlFe08tB4lIawX5MaNYOU6TilZee7uf2 PbE5QP2ZXpXCH2Yme59syev/PVqrI02Z8zmZAvvUYQslkEXiXN4mCgWhGXVmZePE +o+O2bACVAbaRANUZv4vosrPkFI5ooBCn9DR7ME7lZu93nIziMk+xRnzmYacSdQK k2+GSQSmJ4zd0NCDNaYQ0Svhd3KY6jLZ/RaaYjN4ylNiEkNv8Skk+Vz8l4R8bctY VZPJeZI/slNH4LfMV6pDuWjmVirJwrj8CmbrpBbWuILjcFjmwvDXt9mGZDlari9z kK5s4TsAib29bGOPJIjBedmTLuQbaOy6GFppAYQCU063z+n/Jzsyp1ICQGtA5b6P 0PE9WmzQtC7+X15bIL5d =l8oP -----END PGP SIGNATURE-----