From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaehoon Chung Date: Fri, 08 Nov 2013 10:29:22 +0900 Subject: [U-Boot] [PATCH 4/7] mmc: Update the handling of returned erase block In-Reply-To: <1383632633-27262-4-git-send-email-Haijun.Zhang@freescale.com> References: <1383632633-27262-1-git-send-email-Haijun.Zhang@freescale.com> <1383632633-27262-4-git-send-email-Haijun.Zhang@freescale.com> Message-ID: <527C3E72.3090306@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Haijun, Check the below message, plz. cmd_mmc.c: In function ?do_mmcops?: cmd_mmc.c:405:5: warning: comparisons like ?X<=Y<=Z? do not have their mathematical meaning [-Wparentheses] cmd_mmc.c:406:5: warning: comparisons like ?X<=Y<=Z? do not have their mathematical meaning [-Wparentheses] cmd_mmc.c:407:4: warning: comparisons like ?X<=Y<=Z? do not have their mathematical meaning [-Wparentheses] Best Regards, Jaehoon Chung On 11/05/2013 03:23 PM, Haijun Zhang wrote: > If the block rang was not algined, We tried to algined the range, > then erase the block. So the block range erased should be less or > equal to the block range send. If error occured during erase procedure > part of them will be erased. And use should resend the block rang to > continue erase the reset of them. > > Error number and zero number mean erase operation was failed. > > Signed-off-by: Haijun Zhang > --- > common/cmd_mmc.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/common/cmd_mmc.c b/common/cmd_mmc.c > index 67a94a7..15cecb7 100644 > --- a/common/cmd_mmc.c > +++ b/common/cmd_mmc.c > @@ -397,6 +397,13 @@ static int do_mmcops(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) > BUG(); > } > > + if (state == MMC_ERASE) { > + printf("%d blocks %s: %s\n", > + (cnt >= n > 0) ? n : 0, argv[1], > + (cnt >= n > 0) ? "OK" : "ERROR"); > + return (cnt >= n > 0) ? 0 : 1; > + } > + > printf("%d blocks %s: %s\n", > n, argv[1], (n == cnt) ? "OK" : "ERROR"); > return (n == cnt) ? 0 : 1; >