From mboxrd@z Thu Jan 1 00:00:00 1970 From: Prabhakar Kushwaha Date: Sat, 9 Nov 2013 06:22:36 +0530 Subject: [U-Boot] [Patch v1 6/6] Driver/IFC: Move Freescale IFC driver to a common driver In-Reply-To: <1383957845.23598.226.camel@snotra.buserror.net> References: <1383185235-4693-1-git-send-email-yorksun@freescale.com> <1383185235-4693-7-git-send-email-yorksun@freescale.com> <5271CE16.3010202@freescale.com> <1383957845.23598.226.camel@snotra.buserror.net> Message-ID: <527D8754.3080908@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/9/2013 6:14 AM, Scott Wood wrote: > On Thu, 2013-10-31 at 08:57 +0530, Prabhakar Kushwaha wrote: >> On 10/31/2013 7:37 AM, York Sun wrote: >>> Freescale IFC controller has been used for mpc8xxx. It will be used >>> for ARM-based SoC as well. This patch moves the driver to driver/mtd >>> and fix the header file includes. >>> >>> Signed-off-by: York Sun >>> >> Thanks York for this patch. This was pending from long time. >> >> This patch moves fsl_ifc.c from powerpc to driver/mtd >> I am not sure having 2 files for IFC controller in driver/mtd/ is >> correct. Although fsl_ifc.c is for IFC Controller(NOR, NAND machine) and >> fsl_ifc_nand.c is only for IFC - NAND machine. >> I am asking this question as same changes will be applicable in Linux also. >> >> Also, >> We have to move changes of arch/powerpc/cpu/mpc85xx/speed.c to fsl_ifc.c >> . This will make a IFC driver generic. >> >> As this patch has impact on all IFC platforms, has this been tested on >> few platforms? > I'm not sure that drivers/mtd is the right place for it as it doesn't > expose an mtd interface. > > Yes Scott, I am also agree with you. But we are not sure about the right place for it. one suggestion, may we merge fsl_ifc in fsl_ifc_nand.c & fsl_ifc_spl.c? Please advice Regards, Prabhakar