From mboxrd@z Thu Jan  1 00:00:00 1970
From: Igor Grinberg <grinberg@compulab.co.il>
Date: Sun, 10 Nov 2013 17:27:39 +0200
Subject: [U-Boot] [PATCH 2/3] gpio_led: check gpio_request() return value
In-Reply-To: <1383865432-21801-3-git-send-email-grinberg@compulab.co.il>
References: <1383865432-21801-1-git-send-email-grinberg@compulab.co.il>
	<1383865432-21801-3-git-send-email-grinberg@compulab.co.il>
Message-ID: <527FA5EB.7090703@compulab.co.il>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 11/08/13 01:03, Igor Grinberg wrote:
> Add a check for the gpio_request() function return value and do not try
> to configure the GPIO if the gpio_request() call fails.
> Also, print an error message indicating the gpio_request() has failed.
> 
> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>

Tested-by: Ilya Ledvich <ilya@compulab.co.il>

> ---
>  drivers/misc/gpio_led.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/gpio_led.c b/drivers/misc/gpio_led.c
> index 3fedddc..de20419 100644
> --- a/drivers/misc/gpio_led.c
> +++ b/drivers/misc/gpio_led.c
> @@ -11,7 +11,11 @@
>  
>  void __led_init(led_id_t mask, int state)
>  {
> -	gpio_request(mask, "gpio_led");
> +	if (gpio_request(mask, "gpio_led") != 0) {
> +		printf("%s: failed requesting GPIO%lu!\n", __func__, mask);
> +		return;
> +	}
> +
>  	gpio_direction_output(mask, state == STATUS_LED_ON);
>  }
>  
> 

-- 
Regards,
Igor.