From: Paul Burton <paul.burton@imgtec.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 10/18] malta: display "U-boot" on the LCD screen
Date: Mon, 11 Nov 2013 10:36:45 +0000 [thread overview]
Message-ID: <5280B33D.2010708@imgtec.com> (raw)
In-Reply-To: <201311102108.17360.marex@denx.de>
On 10/11/13 20:08, Marek Vasut wrote:
> Dear Paul Burton,
>
>> Displaying a message on the LCD screen is a simple yet effective way to
>> show the user that the board has booted successfully.
>>
>> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
>> ---
>> Changes in v3:
>> - rebase atop master
>>
>> Changes in v2:
>> - rebased after malta moved to board/imgtec/malta
>> ---
>> arch/mips/include/asm/malta.h | 10 ++++++++++
>> board/imgtec/malta/malta.c | 19 +++++++++++++++++++
>> 2 files changed, 29 insertions(+)
>>
>> diff --git a/arch/mips/include/asm/malta.h b/arch/mips/include/asm/malta.h
>> index 0b50a66..d8ec57c 100644
>> --- a/arch/mips/include/asm/malta.h
>> +++ b/arch/mips/include/asm/malta.h
>> @@ -32,6 +32,16 @@
>> #define MALTA_MSC01_PCIIO_MAP 0x00000000
>> #define MALTA_MSC01_UART0_BASE (MALTA_MSC01_PCIIO_BASE + 0x3f8)
>>
>> +#define MALTA_ASCIIWORD 0x1f000410
>> +#define MALTA_ASCIIPOS0 0x1f000418
>> +#define MALTA_ASCIIPOS1 0x1f000420
>> +#define MALTA_ASCIIPOS2 0x1f000428
>> +#define MALTA_ASCIIPOS3 0x1f000430
>> +#define MALTA_ASCIIPOS4 0x1f000438
>> +#define MALTA_ASCIIPOS5 0x1f000440
>> +#define MALTA_ASCIIPOS6 0x1f000448
>> +#define MALTA_ASCIIPOS7 0x1f000450
>> +
>> #define MALTA_RESET_BASE 0x1f000500
>> #define GORESET 0x42
>>
>> diff --git a/board/imgtec/malta/malta.c b/board/imgtec/malta/malta.c
>> index 2af0067..119546a 100644
>> --- a/board/imgtec/malta/malta.c
>> +++ b/board/imgtec/malta/malta.c
>> @@ -29,6 +29,24 @@ enum sys_con {
>> SYSCON_MSC01,
>> };
>>
>> +static void malta_lcd_puts(const char *str)
>> +{
>> + int i;
>> + void *reg = (void *)CKSEG1ADDR(MALTA_ASCIIPOS0);
>> +
>> + /* print up to 8 characters of the string */
>> + for (i = 0; i < min(strlen(str), 8); i++) {
>> + __raw_writel(str[i], reg);
>> + reg += MALTA_ASCIIPOS1 - MALTA_ASCIIPOS0;
>> + }
>> +
>> + /* fill the rest of the display with spaces */
>> + for (; i < 8; i++) {
>> + __raw_writel(' ', reg);
>> + reg += MALTA_ASCIIPOS1 - MALTA_ASCIIPOS0;
>> + }
>> +}
>> +
>> static enum core_card malta_core_card(void)
>> {
>> u32 corid, rev;
>> @@ -71,6 +89,7 @@ int checkboard(void)
>> {
>> enum core_card core;
>>
>> + malta_lcd_puts("U-boot");
>> puts("Board: MIPS Malta");
>>
>> core = malta_core_card();
>
> Can this not be implemented as a regular framebuffer console maybe?
>
> Best regards,
> Marek Vasut
>
We're talking about an 8 character segmented LCD display here - it's not
something you can draw (non-ASCII) graphics on, nor something you want
to be interacting with even if you hooked up some input.
Thanks,
Paul
next prev parent reply other threads:[~2013-11-11 10:36 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 11:18 [U-Boot] [PATCH v1+ 00/18] MIPS Malta board support Paul Burton
2013-11-08 11:18 ` [U-Boot] [PATCH v2 01/18] mips32: detect L1 cache sizes if they're not defined Paul Burton
2013-11-08 11:18 ` [U-Boot] [PATCH v2 02/18] pcnet: code style cleanup Paul Burton
2013-11-08 11:18 ` [U-Boot] [PATCH v2 03/18] pcnet: s/le16_to_cpu/cpu_to_le16/ in pcnet_send Paul Burton
2013-11-08 11:18 ` [U-Boot] [PATCH v2 04/18] pcnet: add cache flushing & invalidation Paul Burton
2013-11-08 11:18 ` [U-Boot] [PATCH v2 05/18] pcnet: enable the NOUFLO feature Paul Burton
2013-11-10 20:02 ` Marek Vasut
2013-11-11 10:22 ` Paul Burton
2013-11-11 13:30 ` Marek Vasut
2013-11-08 11:18 ` [U-Boot] [PATCH v2 06/18] pci.h: allow inclusion in assembly source Paul Burton
2013-11-08 11:18 ` [U-Boot] [PATCH v4 07/18] qemu-malta: rename to just "malta" Paul Burton
2013-11-09 0:53 ` Daniel Schwierzeck
2013-11-09 10:22 ` [U-Boot] [PATCH v5 " Paul Burton
2013-11-10 20:05 ` Marek Vasut
2013-11-11 10:24 ` Paul Burton
2013-11-11 13:30 ` Marek Vasut
2013-11-08 11:18 ` [U-Boot] [PATCH v3 08/18] malta: setup super I/O UARTs Paul Burton
2013-11-10 20:06 ` Marek Vasut
2013-11-11 10:29 ` Paul Burton
2013-11-11 13:31 ` Marek Vasut
2013-11-08 11:18 ` [U-Boot] [PATCH v3 09/18] malta: support for coreFPGA6 boards Paul Burton
2013-11-10 20:07 ` Marek Vasut
2013-11-11 10:32 ` Paul Burton
2013-11-11 10:52 ` Daniel Schwierzeck
2013-11-11 11:03 ` [U-Boot] [PATCH] malta: arch/mips/include/asm/malta.h SPDX license tag Paul Burton
2013-11-11 11:34 ` Daniel Schwierzeck
2013-11-08 11:18 ` [U-Boot] [PATCH v3 10/18] malta: display "U-boot" on the LCD screen Paul Burton
2013-11-10 20:08 ` Marek Vasut
2013-11-11 10:36 ` Paul Burton [this message]
2013-11-11 13:32 ` Marek Vasut
2013-11-08 11:18 ` [U-Boot] [PATCH v2 11/18] malta: enable CONFIG_PCNET_79C973, PCNET_HAS_PROM, CONFIG_CMD_DHCP Paul Burton
2013-11-08 11:18 ` [U-Boot] [PATCH v2 12/18] malta: remove cache size definitions Paul Burton
2013-11-08 11:18 ` [U-Boot] [PATCH v3 13/18] malta: disable L2 caches Paul Burton
2013-11-08 11:18 ` [U-Boot] [PATCH v2 14/18] malta: enable RTC support Paul Burton
2013-11-08 11:18 ` [U-Boot] [PATCH 15/18] malta: store environment in flash Paul Burton
2013-11-08 11:18 ` [U-Boot] [PATCH 16/18] malta: setup PIIX4 interrupt route Paul Burton
2013-11-10 20:09 ` Marek Vasut
2013-11-11 10:57 ` Paul Burton
2013-11-11 13:33 ` Marek Vasut
2013-11-11 13:59 ` Paul Burton
2013-11-11 14:01 ` Marek Vasut
2013-11-08 11:18 ` [U-Boot] [PATCH v3 17/18] malta: add script & instructions to flash U-boot Paul Burton
2013-11-08 11:18 ` [U-Boot] [PATCH v3 18/18] malta: add myself to maintainers Paul Burton
2013-11-09 20:44 ` [U-Boot] [PATCH v1+ 00/18] MIPS Malta board support Daniel Schwierzeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5280B33D.2010708@imgtec.com \
--to=paul.burton@imgtec.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox