From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Burton Date: Mon, 11 Nov 2013 13:59:48 +0000 Subject: [U-Boot] [PATCH 16/18] malta: setup PIIX4 interrupt route In-Reply-To: <201311111433.03271.marex@denx.de> References: <1383909539-29929-1-git-send-email-paul.burton@imgtec.com> <201311102109.30137.marex@denx.de> <5280B815.4090603@imgtec.com> <201311111433.03271.marex@denx.de> Message-ID: <5280E2D4.9080101@imgtec.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/11/13 13:33, Marek Vasut wrote: > Dear Paul Burton, > >> On 10/11/13 20:09, Marek Vasut wrote: >>> Dear Paul Burton, >>> >>>> Without setting up the PIRQ[A:D] interrupt routes, PCI interrupts will >>>> be left disabled. Linux does not set up this routing but relies upon it >>>> having been set up by the bootloader, reading back the IRQ lines which >>>> the PIRQ[A:D] signals have been routed to. >>> >>> Did you also submit a fix to Linux guys? >>> >>> Best regards, >>> Marek Vasut >> >> No, I haven't. Although Linux is reliant upon these values having been >> programmed it's quite clear from reading its code that that depence is >> intentional. It explicitely reads the route setup by the bootloader >> rather than clobbering it, and to me that does make sense in this case. > > Can this setup not be passed via a well-designed DT binding then? I'm sure the information could be passed via DT but the Malta board currently doesn't use DT at all either in Linux or U-boot, and I don't have the time right now to convert them both to DT. > >> However the pcnet32 ethernet driver seems to be reliant upon the >> interrupt and doesn't handle the case of a PCI device with no assigned >> interrupt, so I'll send a patch to fail its probe in that case shortly. > > Thanks! > > Best regards, > Marek Vasut > Thanks, Paul