From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Patch v1 1/6] Driver/DDR: Moving Freescale DDR driver to a common driver
Date: Mon, 11 Nov 2013 12:15:27 -0800 [thread overview]
Message-ID: <52813ADF.5030803@freescale.com> (raw)
In-Reply-To: <1384199954.1403.7.camel@snotra.buserror.net>
On 11/11/2013 11:59 AM, Scott Wood wrote:
> On Mon, 2013-11-11 at 11:37 -0800, York Sun wrote:
>> On 11/11/2013 11:35 AM, Scott Wood wrote:
>>> On Mon, 2013-11-11 at 11:05 -0800, York Sun wrote:
>>>> On 11/11/2013 10:49 AM, Scott Wood wrote:
>>>>> My point is that the type of DDR that is present is hardware
>>>>> description, just as much as the type of DDR controller. "User config"
>>>>> means things users can choose purely in software, without a
>>>>> corresponding hardware change.
>>>>>
>>>>
>>>> This is a board-level configuration, not SoC level. Should we use
>>>> CONFIG_SYS_ as well?
>>>
>>> Yes.
>>>
>>>> If so, we need to come up with a new name, such as CONFIG_SYS_FSL_DDR_MEM_GEN3.
>>>
>>> How about CONFIG_SYS_FSL_DDR3 for the memory, and
>>> CONFIG_SYS_FSL_DDR_CTRL3 for the controller?
>>>
>>
>> I am reluctant to change existing macro to different meaning. How about
>> CONFIG_SYS_FSL_DDR3_MEM, or CONFIG_SYS_FSL_MEM_DDR3?
>
> CONFIG_SYS_FSL_DDR3 is not an existing macro.
>
Oh. My mistake. We can use CONFIG_SYS_FSL_DDR3 for the memory. But I
prefer to keep CONFIG_SYS_FSL_DDR_PPC_GEN3 or use
CONFIG_SYS_FSL_DDRC_GEN3 if it can be merged with ARM controller. CTRL3
is misleading. It makes me thinking of controller #3.
York
next prev parent reply other threads:[~2013-11-11 20:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 2:07 [U-Boot] [Patch v1 0/6] Move Freescale DDR and IFC drivers to common drivers York Sun
2013-10-31 2:07 ` [U-Boot] [Patch v1 1/6] Driver/DDR: Moving Freescale DDR driver to a common driver York Sun
2013-11-09 0:48 ` Scott Wood
2013-11-09 2:25 ` york sun
2013-11-11 18:49 ` Scott Wood
2013-11-11 19:05 ` York Sun
2013-11-11 19:35 ` Scott Wood
2013-11-11 19:37 ` York Sun
2013-11-11 19:59 ` Scott Wood
2013-11-11 20:15 ` York Sun [this message]
2013-11-11 20:25 ` Scott Wood
2013-10-31 2:07 ` [U-Boot] [Patch v1 2/6] Driver/DDR: combine ccsr_ddr for 83xx, 85xx and 86xx York Sun
2013-10-31 2:07 ` [U-Boot] [Patch v1 3/6] Driver/DDR: Add Freescale DDR driver for ARM York Sun
2013-11-09 0:51 ` Scott Wood
2013-11-09 2:29 ` york sun
2013-10-31 2:07 ` [U-Boot] [Patch v1 4/6] powerpc/mpc8xxx: Extend DDR registers' fields York Sun
2013-10-31 2:07 ` [U-Boot] [Patch v1 5/6] Driver/DDR: Update DDR driver to allow non-zero base address York Sun
2013-10-31 2:07 ` [U-Boot] [Patch v1 6/6] Driver/IFC: Move Freescale IFC driver to a common driver York Sun
2013-10-31 3:27 ` Prabhakar Kushwaha
2013-11-09 0:44 ` Scott Wood
2013-11-09 0:52 ` Prabhakar Kushwaha
2013-11-09 1:00 ` Scott Wood
2013-11-11 11:13 ` Prabhakar Kushwaha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52813ADF.5030803@freescale.com \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox