From mboxrd@z Thu Jan 1 00:00:00 1970 From: York Sun Date: Mon, 11 Nov 2013 12:15:27 -0800 Subject: [U-Boot] [Patch v1 1/6] Driver/DDR: Moving Freescale DDR driver to a common driver In-Reply-To: <1384199954.1403.7.camel@snotra.buserror.net> References: <1383185235-4693-1-git-send-email-yorksun@freescale.com> <1383185235-4693-2-git-send-email-yorksun@freescale.com> <1383958138.23598.231.camel@snotra.buserror.net> <52AA82BF-D859-4A21-9CA7-BB646E8908FB@freescale.com> <1384195793.1403 Message-ID: <52813ADF.5030803@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/11/2013 11:59 AM, Scott Wood wrote: > On Mon, 2013-11-11 at 11:37 -0800, York Sun wrote: >> On 11/11/2013 11:35 AM, Scott Wood wrote: >>> On Mon, 2013-11-11 at 11:05 -0800, York Sun wrote: >>>> On 11/11/2013 10:49 AM, Scott Wood wrote: >>>>> My point is that the type of DDR that is present is hardware >>>>> description, just as much as the type of DDR controller. "User config" >>>>> means things users can choose purely in software, without a >>>>> corresponding hardware change. >>>>> >>>> >>>> This is a board-level configuration, not SoC level. Should we use >>>> CONFIG_SYS_ as well? >>> >>> Yes. >>> >>>> If so, we need to come up with a new name, such as CONFIG_SYS_FSL_DDR_MEM_GEN3. >>> >>> How about CONFIG_SYS_FSL_DDR3 for the memory, and >>> CONFIG_SYS_FSL_DDR_CTRL3 for the controller? >>> >> >> I am reluctant to change existing macro to different meaning. How about >> CONFIG_SYS_FSL_DDR3_MEM, or CONFIG_SYS_FSL_MEM_DDR3? > > CONFIG_SYS_FSL_DDR3 is not an existing macro. > Oh. My mistake. We can use CONFIG_SYS_FSL_DDR3 for the memory. But I prefer to keep CONFIG_SYS_FSL_DDR_PPC_GEN3 or use CONFIG_SYS_FSL_DDRC_GEN3 if it can be merged with ARM controller. CTRL3 is misleading. It makes me thinking of controller #3. York