* [U-Boot] [PATCH 1/2] wandboard: Return the error immediately when ipuv3_fb_init() fails
@ 2013-11-04 0:03 Fabio Estevam
2013-11-04 0:03 ` [U-Boot] [PATCH 2/2] wandboard: Return the error when cpu_eth_init() fails Fabio Estevam
2013-11-13 9:14 ` [U-Boot] [PATCH 1/2] wandboard: Return the error immediately when ipuv3_fb_init() fails Stefano Babic
0 siblings, 2 replies; 4+ messages in thread
From: Fabio Estevam @ 2013-11-04 0:03 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@freescale.com>
If ipuv3_fb_init() fails, we should return the error immediately.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
board/wandboard/wandboard.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c
index 23a78c1..99150f9 100644
--- a/board/wandboard/wandboard.c
+++ b/board/wandboard/wandboard.c
@@ -230,8 +230,10 @@ int board_video_skip(void)
ret = ipuv3_fb_init(&hdmi, 0, IPU_PIX_FMT_RGB24);
- if (ret)
+ if (ret) {
printf("HDMI cannot be configured: %d\n", ret);
+ return ret;
+ }
imx_enable_hdmi_phy();
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH 2/2] wandboard: Return the error when cpu_eth_init() fails
2013-11-04 0:03 [U-Boot] [PATCH 1/2] wandboard: Return the error immediately when ipuv3_fb_init() fails Fabio Estevam
@ 2013-11-04 0:03 ` Fabio Estevam
2013-11-13 9:15 ` Stefano Babic
2013-11-13 9:14 ` [U-Boot] [PATCH 1/2] wandboard: Return the error immediately when ipuv3_fb_init() fails Stefano Babic
1 sibling, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2013-11-04 0:03 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@freescale.com>
When cpu_eth_init() fails we should not return success.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
board/wandboard/wandboard.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c
index 99150f9..bf9898c 100644
--- a/board/wandboard/wandboard.c
+++ b/board/wandboard/wandboard.c
@@ -265,7 +265,7 @@ int board_eth_init(bd_t *bis)
if (ret)
printf("FEC MXC: %s:failed\n", __func__);
- return 0;
+ return ret;
}
int board_early_init_f(void)
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH 2/2] wandboard: Return the error when cpu_eth_init() fails
2013-11-04 0:03 ` [U-Boot] [PATCH 2/2] wandboard: Return the error when cpu_eth_init() fails Fabio Estevam
@ 2013-11-13 9:15 ` Stefano Babic
0 siblings, 0 replies; 4+ messages in thread
From: Stefano Babic @ 2013-11-13 9:15 UTC (permalink / raw)
To: u-boot
On 04/11/2013 01:03, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> When cpu_eth_init() fails we should not return success.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH 1/2] wandboard: Return the error immediately when ipuv3_fb_init() fails
2013-11-04 0:03 [U-Boot] [PATCH 1/2] wandboard: Return the error immediately when ipuv3_fb_init() fails Fabio Estevam
2013-11-04 0:03 ` [U-Boot] [PATCH 2/2] wandboard: Return the error when cpu_eth_init() fails Fabio Estevam
@ 2013-11-13 9:14 ` Stefano Babic
1 sibling, 0 replies; 4+ messages in thread
From: Stefano Babic @ 2013-11-13 9:14 UTC (permalink / raw)
To: u-boot
On 04/11/2013 01:03, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> If ipuv3_fb_init() fails, we should return the error immediately.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-11-13 9:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-04 0:03 [U-Boot] [PATCH 1/2] wandboard: Return the error immediately when ipuv3_fb_init() fails Fabio Estevam
2013-11-04 0:03 ` [U-Boot] [PATCH 2/2] wandboard: Return the error when cpu_eth_init() fails Fabio Estevam
2013-11-13 9:15 ` Stefano Babic
2013-11-13 9:14 ` [U-Boot] [PATCH 1/2] wandboard: Return the error immediately when ipuv3_fb_init() fails Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox