From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 2/6] arm: atmel: sama5d3: correct the error define of DIV
Date: Wed, 13 Nov 2013 13:20:51 +0100 [thread overview]
Message-ID: <52836EA3.4040200@gmail.com> (raw)
In-Reply-To: <1383715757-20170-3-git-send-email-voice.shen@atmel.com>
Hi Bo,
On 11/06/2013 06:29 AM, Bo Shen wrote:
> Correct the error define of DIV.
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>
> ---
> Changes in v3:
> - None
>
> Changes in v2:
> - None
>
> arch/arm/include/asm/arch-at91/at91_pmc.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/include/asm/arch-at91/at91_pmc.h b/arch/arm/include/asm/arch-at91/at91_pmc.h
> index 003920c..ed5462c 100644
> --- a/arch/arm/include/asm/arch-at91/at91_pmc.h
> +++ b/arch/arm/include/asm/arch-at91/at91_pmc.h
> @@ -124,8 +124,8 @@ typedef struct at91_pmc {
> #define AT91_PMC_MCKR_MDIV_MASK 0x00000300
> #endif
>
> -#define AT91_PMC_MCKR_PLLADIV_1 0x00001000
> -#define AT91_PMC_MCKR_PLLADIV_2 0x00002000
> +#define AT91_PMC_MCKR_PLLADIV_1 0x00000000
> +#define AT91_PMC_MCKR_PLLADIV_2 0x00001000
this change will touch pm9261 board. I dunno if your change is correct
for that board. I also wonder why one should set bit position 13 in MCKR
... I can't find any source what that bit could be. However mature
documentation for sam9261 (which is the SoC on pm9261) doesn't name bit
position 12 either.
So I'm fine with your change, but please fix the pm9261 board also (use
the PLLADIV_2 define).
>
> #define AT91_PMC_IXR_MOSCS 0x00000001
> #define AT91_PMC_IXR_LOCKA 0x00000002
>
Best regards
Andreas Bie?mann
next prev parent reply other threads:[~2013-11-13 12:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 5:29 [U-Boot] [PATCH v3 0/6] arm: atmel: sama5d3: enable spl boot from SD card Bo Shen
2013-11-06 5:29 ` [U-Boot] [PATCH v3 1/6] arm: atmel: sama5d3: correct the ID for DBGU and PIT Bo Shen
2013-11-13 12:01 ` Andreas Bießmann
2013-11-06 5:29 ` [U-Boot] [PATCH v3 2/6] arm: atmel: sama5d3: correct the error define of DIV Bo Shen
2013-11-13 12:20 ` Andreas Bießmann [this message]
2013-11-14 6:31 ` Bo Shen
2013-11-06 5:29 ` [U-Boot] [PATCH v3 3/6] arm: atmel: sama5d3: the offset of MULA is 18 Bo Shen
2013-11-13 12:23 ` Andreas Bießmann
2013-11-06 5:29 ` [U-Boot] [PATCH v3 4/6] arm: atmel: sama5d3: early enable PIO peripherals Bo Shen
2013-11-13 12:28 ` Andreas Bießmann
2013-11-06 5:29 ` [U-Boot] [PATCH v3 5/6] arm: atmel: add ddr2 initialization function Bo Shen
2013-11-13 13:03 ` Andreas Bießmann
2013-11-14 6:40 ` Bo Shen
2013-11-14 7:42 ` Andreas Bießmann
2013-11-14 10:16 ` Bo Shen
2013-11-06 5:29 ` [U-Boot] [PATCH v3 6/6] arm: atmel: sama5d3: spl boot from fat fs SD card Bo Shen
2013-11-13 13:34 ` Andreas Bießmann
2013-11-14 5:52 ` Heiko Schocher
2013-11-14 6:28 ` Andreas Bießmann
2013-11-14 6:53 ` Bo Shen
2013-11-14 7:49 ` Andreas Bießmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52836EA3.4040200@gmail.com \
--to=andreas.devel@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox