From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 4/6] arm: atmel: sama5d3: early enable PIO peripherals
Date: Wed, 13 Nov 2013 13:28:55 +0100 [thread overview]
Message-ID: <52837087.3000101@gmail.com> (raw)
In-Reply-To: <1383715757-20170-5-git-send-email-voice.shen@atmel.com>
Hi Bo,
On 11/06/2013 06:29 AM, Bo Shen wrote:
> Enable the PIO peripherals early than other peripherals.
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>
> ---
> Changes in v3:
> - Correct the clock enable code, the ID can not OR
>
> Changes in v2:
> - None
>
> board/atmel/sama5d3xek/sama5d3xek.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/board/atmel/sama5d3xek/sama5d3xek.c b/board/atmel/sama5d3xek/sama5d3xek.c
> index b0965ef..f245f98 100644
> --- a/board/atmel/sama5d3xek/sama5d3xek.c
> +++ b/board/atmel/sama5d3xek/sama5d3xek.c
> @@ -158,6 +158,12 @@ void lcd_show_board_info(void)
>
> int board_early_init_f(void)
I'm still not really sure if _board_ init is the right place ... I feel
more like some _arch_ init.
But I would accept it here for getting the first SPL in at91. We need to
rework that whole arch vs. board related init anyways, so we could
change it then (and insisting on that _now_ would definitely break the
release date).
> {
> + at91_periph_clk_enable(ATMEL_ID_PIOA);
> + at91_periph_clk_enable(ATMEL_ID_PIOB);
> + at91_periph_clk_enable(ATMEL_ID_PIOC);
> + at91_periph_clk_enable(ATMEL_ID_PIOD);
> + at91_periph_clk_enable(ATMEL_ID_PIOE);
> +
> at91_seriald_hw_init();
>
> return 0;
>
To say it clear, for this patch no change requested.
Best regards
Andreas Bie?mann
next prev parent reply other threads:[~2013-11-13 12:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 5:29 [U-Boot] [PATCH v3 0/6] arm: atmel: sama5d3: enable spl boot from SD card Bo Shen
2013-11-06 5:29 ` [U-Boot] [PATCH v3 1/6] arm: atmel: sama5d3: correct the ID for DBGU and PIT Bo Shen
2013-11-13 12:01 ` Andreas Bießmann
2013-11-06 5:29 ` [U-Boot] [PATCH v3 2/6] arm: atmel: sama5d3: correct the error define of DIV Bo Shen
2013-11-13 12:20 ` Andreas Bießmann
2013-11-14 6:31 ` Bo Shen
2013-11-06 5:29 ` [U-Boot] [PATCH v3 3/6] arm: atmel: sama5d3: the offset of MULA is 18 Bo Shen
2013-11-13 12:23 ` Andreas Bießmann
2013-11-06 5:29 ` [U-Boot] [PATCH v3 4/6] arm: atmel: sama5d3: early enable PIO peripherals Bo Shen
2013-11-13 12:28 ` Andreas Bießmann [this message]
2013-11-06 5:29 ` [U-Boot] [PATCH v3 5/6] arm: atmel: add ddr2 initialization function Bo Shen
2013-11-13 13:03 ` Andreas Bießmann
2013-11-14 6:40 ` Bo Shen
2013-11-14 7:42 ` Andreas Bießmann
2013-11-14 10:16 ` Bo Shen
2013-11-06 5:29 ` [U-Boot] [PATCH v3 6/6] arm: atmel: sama5d3: spl boot from fat fs SD card Bo Shen
2013-11-13 13:34 ` Andreas Bießmann
2013-11-14 5:52 ` Heiko Schocher
2013-11-14 6:28 ` Andreas Bießmann
2013-11-14 6:53 ` Bo Shen
2013-11-14 7:49 ` Andreas Bießmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52837087.3000101@gmail.com \
--to=andreas.devel@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox