public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 0/5] i.MX6 (DQ/DLS): consolidate mux and pad names
Date: Wed, 13 Nov 2013 14:04:50 -0700	[thread overview]
Message-ID: <5283E972.3070806@boundarydevices.com> (raw)
In-Reply-To: <CAOMZO5CuLQHQtr=B8_ihp3Yi-emzr-jJJK4SOqKZbwtFU-+zNA@mail.gmail.com>

Hi Fabio,

On 11/13/2013 01:07 PM, Fabio Estevam wrote:
> Hi Eric,
>
> On Wed, Nov 13, 2013 at 3:56 PM, Eric Nelson
> <eric.nelson@boundarydevices.com> wrote:
>
>> In the RFC e-mail change regarding README.imx6-something,
>> I proposed that we replace the pad declaration form
>> currently in use:
>>
>> enum {
>>          MX6_PAD_SD3_DAT2__USDHC3_DAT2 = IOMUX_PAD(...)
>> };
>>
>> with macros of this form so that they can be pre-pended
>> with MX6Q_ and MX6DL_ when we need both in an image
>> (SPL?) that can run on either variant of processor.
>>
>>          MX6_PAD_DECL(SD3_DAT2__USDHC3_DAT2, ...)
>
> I thinks this macro approach should work fine. Do we
 > see any objections?
>
Not so far.

I think everybody would rather not have so much macro-fu,
but the only real alternatives are either lots of duplication
or an immediate "big bang" switch to have all boards
support all CPU variants.

Since we have some boards that are expected to be Solo-Only
or Quad-Only forever, we'd like to retain the single-variant
build without explicitly listing the pads as MX6Q_ or MX6DL_.

>>
>> If we do this, then lining up the columns based on the
>> first form doesn't make much sense.
>
> Understood it now. Thanks for clarifying.
>

Cool.

I'll re-base the macro patch I have floating here
and submit it officially.

It's mostly mechanical and easy to validate.

I'll also submit an updated patch for README.imx6,
but will keep it separate because I expect more suggestions
regarding the wording.

Regards,


Eric

      reply	other threads:[~2013-11-13 21:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-05  0:00 [U-Boot] [PATCH V2 0/5] i.MX6 (DQ/DLS): consolidate mux and pad names Eric Nelson
2013-11-05  0:00 ` [U-Boot] [PATCH V2 1/5] i.MX6DQ/DLS: replace pad names with their Linux kernel equivalents Eric Nelson
2013-11-05  0:00 ` [U-Boot] [PATCH V2 2/5] i.MX6DQ/DLS: remove useless mux/pad declarations Eric Nelson
2013-11-05  0:00 ` [U-Boot] [PATCH V2 3/5] i.MX6DQ: Add Pinmux settings that are present in mainline and Dual-Lite/Solo Eric Nelson
2013-11-05  0:00 ` [U-Boot] [PATCH V2 4/5] i.MX6DQ/DLS: remove unused pad declarations Eric Nelson
2013-11-05  0:00 ` [U-Boot] [PATCH V2 5/5] i.MX6DQ/DLS: whitespace: Align IOMUX_PAD column in declarations Eric Nelson
2013-11-13  9:36 ` [U-Boot] [PATCH V2 0/5] i.MX6 (DQ/DLS): consolidate mux and pad names Stefano Babic
2013-11-13 17:23   ` Eric Nelson
2013-11-13 17:30     ` Fabio Estevam
2013-11-13 17:56       ` Eric Nelson
2013-11-13 20:07         ` Fabio Estevam
2013-11-13 21:04           ` Eric Nelson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5283E972.3070806@boundarydevices.com \
    --to=eric.nelson@boundarydevices.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox