[U-Boot] [PATCH v3 4/6] arm: atmel: sama5d3: early enable PIO peripherals

Andreas Bießmann
2013-11-13T12:28:55Z

Hi Bo,

On 11/06/2013 06:29 AM, Bo Shen wrote:
> Enable the PIO peripherals early than other peripherals.
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>
> ---
> Changes in v3:
> - Correct the clock enable code, the ID can not OR
>
> Changes in v2:
> - None
>
> board/atmel/sama5d3xek/sama5d3xek.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/board/atmel/sama5d3xek/sama5d3xek.c b/board/atmel/sama5d3xek/sama5d3xek.c
> index b0965ef..f245f98 100644
> --- a/board/atmel/sama5d3xek/sama5d3xek.c
> +++ b/board/atmel/sama5d3xek/sama5d3xek.c
> @@ -158,6 +158,12 @@ void lcd_show_board_info(void)
>
> int board_early_init_f(void)

I'm still not really sure if _board_ init is the right place ... I feel
more like some _arch_ init.

But I would accept it here for getting the first SPL in at91. We need to
rework that whole arch vs. board related init anyways, so we could
change it then (and insisting on that _now_ would definitely break the
release date).

> {
> + at91_periph_clk_enable(ATMEL_ID_PIOA);
> + at91_periph_clk_enable(ATMEL_ID_PIOB);
> + at91_periph_clk_enable(ATMEL_ID_PIOC);
> + at91_periph_clk_enable(ATMEL_ID_PIOD);
> + at91_periph_clk_enable(ATMEL_ID_PIOE);
> +
> at91_seriald_hw_init();
>
> return 0;
>

To say it clear, for this patch no change requested.

Best regards

Andreas Bie?mann