[U-Boot] [PATCH v3 2/6] arm: atmel: sama5d3: correct the error define of DIV

Bo Shen
2013-11-14T06:31:24Z

Hi Andreas,

On 11/13/2013 08:20 PM, Andreas Bie?mann wrote:
> Hi Bo,
>
> On 11/06/2013 06:29 AM, Bo Shen wrote:
>> Correct the error define of DIV.
>>
>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>>
>> ---
>> Changes in v3:
>> - None
>>
>> Changes in v2:
>> - None
>>
>> arch/arm/include/asm/arch-at91/at91_pmc.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/include/asm/arch-at91/at91_pmc.h b/arch/arm/include/asm/arch-at91/at91_pmc.h
>> index 003920c..ed5462c 100644
>> --- a/arch/arm/include/asm/arch-at91/at91_pmc.h
>> +++ b/arch/arm/include/asm/arch-at91/at91_pmc.h
>> @@ -124,8 +124,8 @@ typedef struct at91_pmc {
>> #define AT91_PMC_MCKR_MDIV_MASK 0x00000300
>> #endif
>>
>> -#define AT91_PMC_MCKR_PLLADIV_1 0x00001000
>> -#define AT91_PMC_MCKR_PLLADIV_2 0x00002000
>> +#define AT91_PMC_MCKR_PLLADIV_1 0x00000000
>> +#define AT91_PMC_MCKR_PLLADIV_2 0x00001000
>
> this change will touch pm9261 board. I dunno if your change is correct
> for that board. I also wonder why one should set bit position 13 in MCKR
> ... I can't find any source what that bit could be. However mature
> documentation for sam9261 (which is the SoC on pm9261) doesn't name bit
> position 12 either.
>
> So I'm fine with your change, but please fix the pm9261 board also (use
> the PLLADIV_2 define).

Ok, thanks.

>>
>> #define AT91_PMC_IXR_MOSCS 0x00000001
>> #define AT91_PMC_IXR_LOCKA 0x00000002
>>
>
> Best regards
>
> Andreas Bie?mann
>

Best Regards,
Bo Shen