From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bo Shen Date: Thu, 14 Nov 2013 14:31:24 +0800 Subject: [U-Boot] [PATCH v3 2/6] arm: atmel: sama5d3: correct the error define of DIV In-Reply-To: <52836EA3.4040200@gmail.com> References: <1383715757-20170-1-git-send-email-voice.shen@atmel.com> <1383715757-20170-3-git-send-email-voice.shen@atmel.com> <52836EA3.4040200@gmail.com> Message-ID: <52846E3C.9060801@atmel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Andreas, On 11/13/2013 08:20 PM, Andreas Bie?mann wrote: > Hi Bo, > > On 11/06/2013 06:29 AM, Bo Shen wrote: >> Correct the error define of DIV. >> >> Signed-off-by: Bo Shen >> >> --- >> Changes in v3: >> - None >> >> Changes in v2: >> - None >> >> arch/arm/include/asm/arch-at91/at91_pmc.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/include/asm/arch-at91/at91_pmc.h b/arch/arm/include/asm/arch-at91/at91_pmc.h >> index 003920c..ed5462c 100644 >> --- a/arch/arm/include/asm/arch-at91/at91_pmc.h >> +++ b/arch/arm/include/asm/arch-at91/at91_pmc.h >> @@ -124,8 +124,8 @@ typedef struct at91_pmc { >> #define AT91_PMC_MCKR_MDIV_MASK 0x00000300 >> #endif >> >> -#define AT91_PMC_MCKR_PLLADIV_1 0x00001000 >> -#define AT91_PMC_MCKR_PLLADIV_2 0x00002000 >> +#define AT91_PMC_MCKR_PLLADIV_1 0x00000000 >> +#define AT91_PMC_MCKR_PLLADIV_2 0x00001000 > > this change will touch pm9261 board. I dunno if your change is correct > for that board. I also wonder why one should set bit position 13 in MCKR > ... I can't find any source what that bit could be. However mature > documentation for sam9261 (which is the SoC on pm9261) doesn't name bit > position 12 either. > > So I'm fine with your change, but please fix the pm9261 board also (use > the PLLADIV_2 define). Ok, thanks. >> >> #define AT91_PMC_IXR_MOSCS 0x00000001 >> #define AT91_PMC_IXR_LOCKA 0x00000002 >> > > Best regards > > Andreas Bie?mann > Best Regards, Bo Shen